From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: [PATCH] proc_fs.h redux Date: Sun, 28 Oct 2007 13:04:29 +0000 Message-ID: <20071028130429.GC12554@flint.arm.linux.org.uk> References: <20071027194758.GD9816@martell.zuzino.mipt.ru> <1193524804.26695.103.camel@localhost> <20071028103415.GA12554@flint.arm.linux.org.uk> <20071028115952.GA18479@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arch@vger.kernel.org, Joe Perches , Alexey Dobriyan , akpm@o Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:43277 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754475AbXJ1NJr (ORCPT ); Sun, 28 Oct 2007 09:09:47 -0400 Content-Disposition: inline In-Reply-To: <20071028115952.GA18479@suse.de> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, Oct 28, 2007 at 12:59:52PM +0100, Bernhard Walle wrote: > * Russell King [2007-10-28 11:34]: > > > > If you go down that route, you end up with _lots_ of circular > > dependencies - header file X needs Y needs Z which needs X. We've > > been there, several times. It very quickly becomes quite > > unmaintainable - you end up with hard to predict behaviour from > > include files. > > > > The only realistic solution is to use forward declarations. > > In header files, yes. But that's not true for implementation files. I don't think that needs saying - it's quite obvious. You can't access the contents of structures without their definitions being available. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: