From: David Miller <davem@davemloft.net>
To: eliezert@broadcom.com
Cc: mchan@broadcom.com, jeff@garzik.org, netdev@vger.kernel.org,
masbock@us.ibm.com
Subject: Re: [RFC][BNX2X] .h files rewrite
Date: Mon, 29 Oct 2007 01:39:31 -0700 (PDT) [thread overview]
Message-ID: <20071029.013931.203090879.davem@davemloft.net> (raw)
In-Reply-To: <1193602875.4836.28.camel@eliezer>
From: "Eliezer Tamir" <eliezert@broadcom.com>
Date: Sun, 28 Oct 2007 22:21:14 +0200
Overall things look significantly better, thanks a lot!
However, there is still one set of magic constants in here
which I hope you can clear up:
> +static const struct raw_op init_ops[] = {
> +#define PRS_COMMON_START 0
> + {OP_WR, PRS_REG_INC_VALUE, 0xf},
> + {OP_WR, PRS_REG_EVENT_ID_1, 0x45},
> + {OP_WR, PRS_REG_EVENT_ID_2, 0x84},
> + {OP_WR, PRS_REG_EVENT_ID_3, 0x6},
> + {OP_WR, PRS_REG_NO_MATCH_EVENT_ID, 0x4},
> + {OP_WR, PRS_REG_CM_HDR_TYPE_0, 0x0},
> + {OP_WR, PRS_REG_CM_HDR_TYPE_1, 0x12170000},
> + {OP_WR, PRS_REG_CM_HDR_TYPE_2, 0x22170000},
> + {OP_WR, PRS_REG_CM_HDR_TYPE_3, 0x32170000},
> + {OP_ZR, PRS_REG_CM_HDR_TYPE_4, 0x5},
> + {OP_WR, PRS_REG_CM_HDR_LOOPBACK_TYPE_1, 0x12150000},
> + {OP_WR, PRS_REG_CM_HDR_LOOPBACK_TYPE_2, 0x22150000},
> + {OP_WR, PRS_REG_CM_HDR_LOOPBACK_TYPE_3, 0x32150000},
> + {OP_ZR, PRS_REG_CM_HDR_LOOPBACK_TYPE_4, 0x4},
etc. etc.
Take care.
next prev parent reply other threads:[~2007-10-29 8:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 20:17 [RFC][BNX2X] .h files rewrite Eliezer Tamir
[not found] ` <1193602875.4836.28.camel@eliezer>
2007-10-29 8:39 ` David Miller [this message]
2007-10-31 10:14 ` Eliezer Tamir
2007-10-31 10:53 ` David Miller
2007-11-02 23:35 ` Max Asbock
2007-11-04 7:47 ` Eliezer Tamir
2007-11-12 23:13 ` Ram Pai
2007-11-12 23:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029.013931.203090879.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eliezert@broadcom.com \
--cc=jeff@garzik.org \
--cc=masbock@us.ibm.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).