From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: IPVS: use proper timeout instead of fixed value Date: Mon, 29 Oct 2007 03:01:27 -0700 (PDT) Message-ID: <20071029.030127.206917690.davem@davemloft.net> References: <20071029070555.78D694FA13@tabatha.lab.ultramonkey.org> <20071029.013515.07385320.davem@davemloft.net> <20071029085921.GB30256@verge.net.au> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, lvs-devel@linuxvirtualserver.org, wensong@linux-vs.org, ja@ssi.bg, jmack@wm7d.net, graeme@graemef.net, lvs@rsv.se, andy@greyhouse.net To: horms@verge.net.au Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:51842 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751816AbXJ2KB0 (ORCPT ); Mon, 29 Oct 2007 06:01:26 -0400 In-Reply-To: <20071029085921.GB30256@verge.net.au> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Simon Horman Date: Mon, 29 Oct 2007 17:59:23 +0900 > On Mon, Oct 29, 2007 at 01:35:15AM -0700, David Miller wrote: > > From: Simon Horman > > Date: Mon, 29 Oct 2007 16:05:55 +0900 (JST) > > > > > From: Andy Gospodarek > > > > > > Instead of using the default timeout of 3 minutes, this uses the timeout > > > specific to the protocol used for the connection. The 3 minute timeout > > > seems somewhat arbitrary (though I know it is used other places in the > > > ipvs code) and when failing over it would be much nicer to use one of > > > the configured timeout values. > > > > > > Signed-off-by: Andy Gospodarek > > > Acked-by: Simon Horman > > > > I would apply this but it does not apply to current 2.6.x, > > please resubmit. > > I tried against net-2.6 and it seemed to work. > Was I mistaken or should I be using a different tree? Nope, that should be good. Maybe I did something stupid or it got clobbered in transit somehow. Please resend it privately to me under seperate cover and we'll sort it out. Thanks Simon!