From: "Denys" <denys@visp.net.lb>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org
Subject: Re: HFSC dangerous behaviour (not a bug)
Date: Mon, 29 Oct 2007 13:45:26 +0200 [thread overview]
Message-ID: <20071029114405.M87941@visp.net.lb> (raw)
In-Reply-To: <4725BC23.7000907@trash.net>
After thinking about that, i can say only thanks.
I like your idea, and it is better to avoid mistakes and missed traffic, then
have a lot of complaints from users "why my shaper not working well". And
seems i will try to switch to HFSC.
Thanks for explanation.
On Mon, 29 Oct 2007 11:55:31 +0100, Patrick McHardy wrote
> Denys wrote:
> > Hi All
> >
> > During testing i found very strange thing.
> > After applying even example shaper:
> > http://linux-ip.net/tc/hfsc.en/
> > -------------
> > [...]
> > ---------------
> > I had all traffic on eth0 stopped. Tried on br0 - same result. Even ARP
> > becoming non-functional.
> >
> > After specifying correct default class everything worked fine.
> >
> > In HTB if you dont specify default class, traffic just pass without
> > "shaping".
>
> HFSC drops unclassified packets. If you don't classify ARP properly,
> things will break,
>
> > Is it possible to keep same behaviour on both disciplines?
> > Probably just dropping all traffic not good idea, cause if user working
on
> > remote box by forgetting specifying default class or by mistake using
> > incorrect class number he will loose access to the box, if same interface
is
> > used for tests on shaping and access.
> > In same time it is good, and can show accurate results on shaping,
without
> > bypassing some "forgotten" traffic.
> > But at least it must be same, IMHO, on HTB and HFSC.
>
> This came up a couple of times already. I don't like HTB's behaviour
> since you don't notice when your classifiers are incomplete. So I'm
> against changing HFSC to behave similar. HTB OTOH can't be changed
> since users probably rely on that, not classifying ARP is a common
> mistake.
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Denys Fedoryshchenko
Technical Manager
Virtual ISP S.A.L.
next prev parent reply other threads:[~2007-10-29 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 0:02 HFSC dangerous behaviour (not a bug) Denys
2007-10-29 10:55 ` Patrick McHardy
2007-10-29 11:45 ` Denys [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-29 0:55 Denys
2007-10-29 10:56 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029114405.M87941@visp.net.lb \
--to=denys@visp.net.lb \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).