From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Arnaldo Carvalho de Melo" <acme@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] inet: race in wait for connect.
Date: Mon, 29 Oct 2007 14:37:14 -0700 [thread overview]
Message-ID: <20071029143714.152e0431@freepuppy.rosehill> (raw)
In-Reply-To: <20071029212906.GE21178@ghostprotocols.net>
On Mon, 29 Oct 2007 19:29:06 -0200
"Arnaldo Carvalho de Melo" <acme@redhat.com> wrote:
> Em Mon, Oct 29, 2007 at 01:52:22PM -0700, Stephen Hemminger escreveu:
> > Fix possible race while waiting for connections in accept. I don't
> > know of a test case that could reproduce this directly.
> >
> > The state of the socket should be checked before checking the queue.
> > If the socket has left the TCP_LISTEN state, then the accept queue
> > is no longer valid.
>
> Well if it left from LISTEN to CLOSED inet_csk_listen_stop must have
> been called, and that calls reqsk_queue_yank_acceptq, that sets it to
> NULL, reqsk_queue_empty(&icsk->icsk_accept_queue) returns true and we
> get to if (sk->sk_state != TCP_LISTEN), returning -EINVAL as with your
> patch. So I can't see a race, just one branch less in one case :-)
>
> - Arnaldo
Yeah, your right. The listen queue is garbage at this point but the
accept queue is always empty.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-29 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 20:52 [PATCH] inet: race in wait for connect Stephen Hemminger
2007-10-29 21:29 ` Arnaldo Carvalho de Melo
2007-10-29 21:37 ` Stephen Hemminger [this message]
2007-10-29 22:38 ` David Miller
2007-10-29 23:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029143714.152e0431@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).