From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface
Date: Tue, 30 Oct 2007 08:30:43 -0700 [thread overview]
Message-ID: <20071030083043.47f5def3@freepuppy.rosehill> (raw)
In-Reply-To: <20071030131147.GA6210@localhost.sw.ru>
On Tue, 30 Oct 2007 16:11:47 +0300
Alexey Dobriyan <adobriyan@sw.ru> wrote:
>
> +static const struct file_operations ipv6_route_proc_fops = {
> + .open = ipv6_route_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> +};
> +
This needs
.owner = THIS_MODULE,
>
> static int rt6_stats_seq_show(struct seq_file *seq, void *v)
> {
> seq_printf(seq, "%04x %04x %04x %04x %04x %04x %04x\n",
> @@ -2499,9 +2477,11 @@ void __init ip6_route_init(void)
>
> fib6_init();
> #ifdef CONFIG_PROC_FS
> - p = proc_net_create(&init_net, "ipv6_route", 0, rt6_proc_info);
> - if (p)
> + p = create_proc_entry("ipv6_route", 0, init_net.proc_net);
> + if (p) {
> p->owner = THIS_MODULE;
> + p->proc_fops = &ipv6_route_proc_fops;
> + }
>
> proc_net_fops_create(&init_net, "rt6_stats", S_IRUGO, &rt6_stats_seq_fops);
> #endif
>
Use proc_net_fops_create()
proc_net_fops_create(&init_net, "ipv6_route", S_IRUGO, &ipv6_route_proc_fops)
You can get rid of #ifdef since proc_net_fops_create stub does correct thing
if PROC_FS is not configured.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-30 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 13:11 [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface Alexey Dobriyan
2007-10-30 13:35 ` Benjamin Thery
2007-10-30 13:46 ` Benjamin Thery
2007-10-30 15:30 ` Stephen Hemminger [this message]
2007-10-30 15:37 ` Patrick McHardy
2007-10-30 22:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030083043.47f5def3@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=adobriyan@sw.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox