From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dale Farnsworth" Subject: Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines Date: Tue, 30 Oct 2007 03:22:57 -0700 Message-ID: <20071030102256.GA10170@xyzzy.farnsworth.org> References: <20071029212729.GA4074@pogo> <20071029223900.GA7097@xyzzy.farnsworth.org> <43e72e890710300044o60bfc46cv8815226e39634996@mail.gmail.com> <20071030093606.GA20920@powerlinux.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Luis R. Rodriguez" , netdev@vger.kernel.org, Tzachi Perelstein , Lennert Buytenhek , Jeff Garzik , linuxppc-dev@ozlabs.org To: Sven Luther Return-path: Received: from xyzzy.farnsworth.org ([65.39.95.219]:33324 "HELO farnsworth.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751936AbXJ3KXB (ORCPT ); Tue, 30 Oct 2007 06:23:01 -0400 Content-Disposition: inline In-Reply-To: <20071030093606.GA20920@powerlinux.fr> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Oct 30, 2007 at 10:36:06AM +0100, Sven Luther wrote: > On Tue, Oct 30, 2007 at 03:44:59AM -0400, Luis R. Rodriguez wrote: > > On 10/29/07, Dale Farnsworth wrote: > > > On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: > > > > This commit made an incorrect assumption: > > > > -- > > > > Author: Lennert Buytenhek > > > > Date: Fri Oct 19 04:10:10 2007 +0200 > > > > > > > > mv643xx_eth: Move ethernet register definitions into private header > > > > > > > > Move the mv643xx's ethernet-related register definitions from > > > > include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since > > > > they aren't of any use outside the ethernet driver. > > > > > > > > Signed-off-by: Lennert Buytenhek > > > > Acked-by: Tzachi Perelstein > > > > Signed-off-by: Dale Farnsworth > > > > -- > > > > > > > > arch/powerpc/platforms/chrp/pegasos_eth.c made use of a 3 defines there. > > > > > > > > mcgrof@pogo:~/devel/wireless-2.6$ git-describe > > > > > > > > v2.6.24-rc1-138-g0119130 > > > > > > > > This patch fixes this by internalizing 3 defines onto pegasos which are > > > > simply no longer available elsewhere. Without this your compile will fail > > > > > > That compile failure was fixed in commit > > > 30e69bf4cce16d4c2dcfd629a60fcd8e1aba9fee by Al Viro. > > > > > > However, as I examine that commit, I see that it defines offsets from > > > the eth block in the chip, rather than the full chip registeri block > > > as the Pegasos 2 code expects. So, I think it fixes the compile > > > failure, but leaves the Pegasos 2 broken. > > > > > > Luis, do you have Pegasos 2 hardware? Can you (or anyone) verify that > > > the following patch is needed for the Pegasos 2? > > > > Nope, sorry. > > I am busy right now, but have various pegasos machines available for > testing. What exactly should i test ? Thanks Sven. Test whether an Ethernet port works at all. I think it's currently broken, but should work with the patch I supplied. -Dale