From: Jens Axboe <jens.axboe@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops
Date: Tue, 30 Oct 2007 15:17:54 +0100 [thread overview]
Message-ID: <20071030141754.GT4993@kernel.dk> (raw)
In-Reply-To: <20071030141820.GA16501@gondor.apana.org.au>
On Tue, Oct 30 2007, Herbert Xu wrote:
> On Tue, Oct 30, 2007 at 06:50:58AM +0100, Jens Axboe wrote:
> >
> > How so? The reason you changed it to sg_init_table() + sg_set_buf() is
> > exactly because sg_init_one() didn't properly init the entry (as they
> > name promised).
>
> For one of the cases yes but the other one repeatedly calls
> sg_init_one on the same sg entry while we really only need
> to initialise it once and call sg_set_buf afterwards.
>
> Normally this is irrelevant but the loops in question are
> trying to estimate the speed of the algorithms so it's good
> to exclude as much noise from them as possible.
Ah OK, I was referring to the replacement mentioned above.
--
Jens Axboe
next prev parent reply other threads:[~2007-10-30 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 14:59 [0/2] [CRYPTO] users: Fix up remaining sg issues Herbert Xu
2007-10-26 15:00 ` [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops Herbert Xu
2007-10-27 7:51 ` David Miller
2007-10-29 20:16 ` Jens Axboe
2007-10-30 0:08 ` Herbert Xu
2007-10-30 5:50 ` Jens Axboe
2007-10-30 14:18 ` Herbert Xu
2007-10-30 14:17 ` Jens Axboe [this message]
2007-10-30 9:31 ` Boaz Harrosh
2007-10-30 9:32 ` Jens Axboe
2007-10-26 15:00 ` [PATCH 2/2] [CRYPTO] users: Fix up scatterlist conversion errors Herbert Xu
2007-10-26 15:44 ` Vlad Yasevich
2007-10-27 7:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030141754.GT4993@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).