From: Jens Axboe <jens.axboe@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au,
rusty@rustcorp.com.au
Subject: Re: [PATCH]: Fix networking scatterlist regressions.
Date: Wed, 31 Oct 2007 08:47:09 +0100 [thread overview]
Message-ID: <20071031074708.GC5059@kernel.dk> (raw)
In-Reply-To: <20071031.004320.175325164.davem@davemloft.net>
On Wed, Oct 31 2007, David Miller wrote:
> From: Jens Axboe <jens.axboe@oracle.com>
> Date: Wed, 31 Oct 2007 08:32:07 +0100
>
> > [SG] Remove __sg_mark_end()
> >
> > Make sg_mark_end() NOT overwrite the page link. Then it can be used
> > after filling the sg table, which is what users want. That means that
> > __sg_mark_end() is no longer useful, so kill it.
> >
> > It's important the sg entries be initialized before using sg_mark_end(),
> > so also add a debug check to catch use-before-init.
> >
> > Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
>
> Ok, but I just pushed my changes to Linus and once those show up
> you'll need to extend this patch to kill the '__' prefix from
> all the rest of the calls which will be in the tree.
>
> Thanks!
No problem, I'll base further sg_mark_end() updates on top of yours.
Just need to get that last email I sent out resolved, the
gss_krb5_crypto bits.
--
Jens Axboe
next prev parent reply other threads:[~2007-10-31 7:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 3:40 [PATCH]: Fix networking scatterlist regressions David Miller
2007-10-31 6:06 ` Rusty Russell
2007-10-31 6:44 ` David Miller
2007-10-31 7:32 ` Jens Axboe
2007-10-31 7:43 ` David Miller
2007-10-31 7:47 ` Jens Axboe [this message]
2007-10-31 7:46 ` Jens Axboe
2007-10-31 7:58 ` David Miller
2007-10-31 8:01 ` Jens Axboe
2007-10-31 8:08 ` David Miller
2007-10-31 8:08 ` Jens Axboe
2007-10-31 8:14 ` Jens Axboe
2007-10-31 9:26 ` David Miller
2007-10-31 9:29 ` Jens Axboe
2007-10-31 13:45 ` Herbert Xu
2007-10-31 13:46 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031074708.GC5059@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).