* Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames
[not found] <bug-9270-10286@http.bugzilla.kernel.org/>
@ 2007-10-31 22:43 ` Andrew Morton
2007-10-31 23:35 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2007-10-31 22:43 UTC (permalink / raw)
To: netdev; +Cc: bugme-daemon, dev-null
On Wed, 31 Oct 2007 14:54:06 -0700 (PDT)
bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9270
>
> Summary: sunhme requires lower MTU to handle 802.1q frames
> Product: Drivers
> Version: 2.5
> KernelVersion: 2.6.18-3
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Network
> AssignedTo: jgarzik@pobox.com
> ReportedBy: dev-null@telus.net
>
>
> Most recent kernel where this bug did not occur: N/A
> Distribution: Debian 4.0r1 (Etch)
> Hardware Environment: Sun Netra T1 105
> Software Environment:
> Problem Description:
> sunhme requires lower MTU to handle 802.1q frames - even though the PCI
> driver supported VLAN tagging, you cannot do full MTU @ 1500 because the
> driver doesn't set the card to transfer more the extra bytes for a 802.1q
> frame at 1500 MTU.
>
> Steps to reproduce:
> modprobe 8021q
> modprobe sunhme
> ifconfig eth0 up
> vconfig set_name_type DEV_PLUS_VID_NO_PAD
> vconfig add eth0 10
> ifconfig eth0.10 192.l68.0.1 netmask 255.255.255.252 broadcast 192.168.0.3 up
> # IP pkt size = 1496, Ethernet frame size = 1514
> ping -s 1468 -c 1 -w 1 192.168.0.2
> # IP pkt size = 1500, Ethernet frame size = 1518
> ping -s 1472 -c 1 -w 1 192.168.0.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames
2007-10-31 22:43 ` [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames Andrew Morton
@ 2007-10-31 23:35 ` David Miller
2007-11-01 19:12 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2007-10-31 23:35 UTC (permalink / raw)
To: akpm; +Cc: netdev, bugme-daemon, dev-null, jeff
From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 31 Oct 2007 15:43:01 -0700
> > sunhme requires lower MTU to handle 802.1q frames - even though the PCI
> > driver supported VLAN tagging, you cannot do full MTU @ 1500 because the
> > driver doesn't set the card to transfer more the extra bytes for a 802.1q
> > frame at 1500 MTU.
It supports VLAN tagging by accident, the NETIF_F_VLAN_CHALLENGED
flag should be set both in the PCI and non-PCI cases.
Jeff, please apply, thanks:
[SUNHME]: Fix missing NETIF_F_VLAN_CHALLENGED on PCI happy meals.
No HME parts can do VLANs correctly.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
index 120c8af..c20a3bd 100644
--- a/drivers/net/sunhme.c
+++ b/drivers/net/sunhme.c
@@ -3143,8 +3143,8 @@ static int __devinit happy_meal_pci_probe(struct pci_dev *pdev,
dev->irq = pdev->irq;
dev->dma = 0;
- /* Happy Meal can do it all... */
- dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
+ /* Happy Meal can do it all... except VLAN. */
+ dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_VLAN_CHALLENGED;
#if defined(CONFIG_SBUS) && defined(CONFIG_PCI)
/* Hook up PCI register/dma accessors. */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames
2007-10-31 23:35 ` David Miller
@ 2007-11-01 19:12 ` Andrew Morton
2007-11-01 20:52 ` Chris Poon
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2007-11-01 19:12 UTC (permalink / raw)
To: David Miller; +Cc: netdev, bugme-daemon, dev-null, jeff
On Wed, 31 Oct 2007 16:35:57 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Wed, 31 Oct 2007 15:43:01 -0700
>
> > > sunhme requires lower MTU to handle 802.1q frames - even though the PCI
> > > driver supported VLAN tagging, you cannot do full MTU @ 1500 because the
> > > driver doesn't set the card to transfer more the extra bytes for a 802.1q
> > > frame at 1500 MTU.
>
> It supports VLAN tagging by accident, the NETIF_F_VLAN_CHALLENGED
> flag should be set both in the PCI and non-PCI cases.
>
> Jeff, please apply, thanks:
>
> [SUNHME]: Fix missing NETIF_F_VLAN_CHALLENGED on PCI happy meals.
>
> No HME parts can do VLANs correctly.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
> index 120c8af..c20a3bd 100644
> --- a/drivers/net/sunhme.c
> +++ b/drivers/net/sunhme.c
> @@ -3143,8 +3143,8 @@ static int __devinit happy_meal_pci_probe(struct pci_dev *pdev,
> dev->irq = pdev->irq;
> dev->dma = 0;
>
> - /* Happy Meal can do it all... */
> - dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
> + /* Happy Meal can do it all... except VLAN. */
> + dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_VLAN_CHALLENGED;
>
> #if defined(CONFIG_SBUS) && defined(CONFIG_PCI)
> /* Hook up PCI register/dma accessors. */
I forgot to add my standard "please reply via emailed reply-to-all, not via
the bugzilla web interface", so Chris has gone and attempted to communicate
with us via the bugzilla UI (sigh).
He asked
"Even though it appears to work after I bumped the BMAC_TXMAX / BMAC_RXMAX?"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames
2007-11-01 19:12 ` Andrew Morton
@ 2007-11-01 20:52 ` Chris Poon
0 siblings, 0 replies; 4+ messages in thread
From: Chris Poon @ 2007-11-01 20:52 UTC (permalink / raw)
To: Andrew Morton; +Cc: David Miller, netdev, bugme-daemon, jeff
Forgot to add that only changing BMAC_TXMAX & BMAC_RXMAX wouldn't work
for me, until I changed 2 skb_put as well (which is in the patch that
I submitted in bugzilla). Dug up some really old threads on the net
and found out that this was reported before
Quoting Andrew Morton <akpm@linux-foundation.org>:
> On Wed, 31 Oct 2007 16:35:57 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Date: Wed, 31 Oct 2007 15:43:01 -0700
> >
> > > > sunhme requires lower MTU to handle 802.1q frames - even though the
> PCI
> > > > driver supported VLAN tagging, you cannot do full MTU @ 1500 because
> the
> > > > driver doesn't set the card to transfer more the extra bytes for a
> 802.1q
> > > > frame at 1500 MTU.
> >
> > It supports VLAN tagging by accident, the NETIF_F_VLAN_CHALLENGED
> > flag should be set both in the PCI and non-PCI cases.
> >
> > Jeff, please apply, thanks:
> >
> > [SUNHME]: Fix missing NETIF_F_VLAN_CHALLENGED on PCI happy meals.
> >
> > No HME parts can do VLANs correctly.
> >
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> > diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
> > index 120c8af..c20a3bd 100644
> > --- a/drivers/net/sunhme.c
> > +++ b/drivers/net/sunhme.c
> > @@ -3143,8 +3143,8 @@ static int __devinit happy_meal_pci_probe(struct
> pci_dev *pdev,
> > dev->irq = pdev->irq;
> > dev->dma = 0;
> >
> > - /* Happy Meal can do it all... */
> > - dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
> > + /* Happy Meal can do it all... except VLAN. */
> > + dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_VLAN_CHALLENGED;
> >
> > #if defined(CONFIG_SBUS) && defined(CONFIG_PCI)
> > /* Hook up PCI register/dma accessors. */
>
> I forgot to add my standard "please reply via emailed reply-to-all, not via
> the bugzilla web interface", so Chris has gone and attempted to communicate
> with us via the bugzilla UI (sigh).
>
> He asked
>
> "Even though it appears to work after I bumped the BMAC_TXMAX / BMAC_RXMAX?"
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-01 22:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-9270-10286@http.bugzilla.kernel.org/>
2007-10-31 22:43 ` [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames Andrew Morton
2007-10-31 23:35 ` David Miller
2007-11-01 19:12 ` Andrew Morton
2007-11-01 20:52 ` Chris Poon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).