From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] e1000, e1000e valid-addr fixes Date: Thu, 1 Nov 2007 11:11:56 -0700 Message-ID: <20071101111157.7f3e4f58@freepuppy.rosehill> References: <20071023.145339.55504234.davem@davemloft.net> <471E9801.2000006@garzik.org> <471E99E8.6030404@garzik.org> <20071023.180744.115914004.davem@davemloft.net> <471EABEE.8030900@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, davej@redhat.com, auke-jan.h.kok@intel.com, ajax@redhat.com, linux-kernel@vger.kernel.org To: Jeff Garzik Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:48093 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753273AbXKASNq (ORCPT ); Thu, 1 Nov 2007 14:13:46 -0400 In-Reply-To: <471EABEE.8030900@garzik.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org How about: static int eth_validate_addr(const struct net_device *dev) { return is_valid_ether_addr(dev->dev_addr) ? 0 : -EINVAL; } -- Stephen Hemminger