From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
dev-null@telus.net, jeff@garzik.org
Subject: Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames
Date: Thu, 1 Nov 2007 12:12:39 -0700 [thread overview]
Message-ID: <20071101121239.d0e67bd3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071031.163557.73546666.davem@davemloft.net>
On Wed, 31 Oct 2007 16:35:57 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Wed, 31 Oct 2007 15:43:01 -0700
>
> > > sunhme requires lower MTU to handle 802.1q frames - even though the PCI
> > > driver supported VLAN tagging, you cannot do full MTU @ 1500 because the
> > > driver doesn't set the card to transfer more the extra bytes for a 802.1q
> > > frame at 1500 MTU.
>
> It supports VLAN tagging by accident, the NETIF_F_VLAN_CHALLENGED
> flag should be set both in the PCI and non-PCI cases.
>
> Jeff, please apply, thanks:
>
> [SUNHME]: Fix missing NETIF_F_VLAN_CHALLENGED on PCI happy meals.
>
> No HME parts can do VLANs correctly.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
> index 120c8af..c20a3bd 100644
> --- a/drivers/net/sunhme.c
> +++ b/drivers/net/sunhme.c
> @@ -3143,8 +3143,8 @@ static int __devinit happy_meal_pci_probe(struct pci_dev *pdev,
> dev->irq = pdev->irq;
> dev->dma = 0;
>
> - /* Happy Meal can do it all... */
> - dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
> + /* Happy Meal can do it all... except VLAN. */
> + dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_VLAN_CHALLENGED;
>
> #if defined(CONFIG_SBUS) && defined(CONFIG_PCI)
> /* Hook up PCI register/dma accessors. */
I forgot to add my standard "please reply via emailed reply-to-all, not via
the bugzilla web interface", so Chris has gone and attempted to communicate
with us via the bugzilla UI (sigh).
He asked
"Even though it appears to work after I bumped the BMAC_TXMAX / BMAC_RXMAX?"
next prev parent reply other threads:[~2007-11-01 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9270-10286@http.bugzilla.kernel.org/>
2007-10-31 22:43 ` [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames Andrew Morton
2007-10-31 23:35 ` David Miller
2007-11-01 19:12 ` Andrew Morton [this message]
2007-11-01 20:52 ` Chris Poon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101121239.d0e67bd3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=dev-null@telus.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).