From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.23] [PPP]: L2TP: Fix oops in transmit and receive paths
Date: Mon, 05 Nov 2007 23:33:15 -0800 (PST) [thread overview]
Message-ID: <20071105.233315.59663737.davem@davemloft.net> (raw)
In-Reply-To: <200711051717.lA5HHd9u013301@quickie.katalix.com>
From: James Chapman <jchapman@katalix.com>
Date: Mon, 5 Nov 2007 17:17:39 GMT
> [PPP]: L2TP: Fix oops in transmit and receive paths
>
> Changes made on 18-sep to fix skb handling in the pppol2tp driver
> broke the transmit and receive paths. Users are only running into this
> now because distros are now using 2.6.23 and I must have messed up
> when I tested the change.
>
> For receive, we now do our own calculation of how much to pull from
> the skb (variable length L2TP header) rather than using
> skb_transport_offset(). Also, if the skb isn't a data packet, it must
> be passed back to UDP with skb->data pointing to the UDP header.
>
> For transmit, make sure skb->sk is set up because ip_queue_xmit()
> needs it.
>
> Signed-off-by: James Chapman <jchapman@katalix.com>
Applied, thanks James.
I'll queue this up for -stable too.
prev parent reply other threads:[~2007-11-06 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 17:17 [PATCH 2.6.23] [PPP]: L2TP: Fix oops in transmit and receive paths James Chapman
2007-11-06 7:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105.233315.59663737.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox