From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: David Miller <davem@davemloft.net>
Cc: cebbert@redhat.com, netdev@vger.kernel.org
Subject: Re: kernel panic removing devices from a teql queuing discipline
Date: Mon, 5 Nov 2007 23:08:00 +0300 [thread overview]
Message-ID: <20071105200800.GA4075@2ka.mipt.ru> (raw)
In-Reply-To: <20071030.013341.205362893.davem@davemloft.net>
On Tue, Oct 30, 2007 at 01:33:41AM -0700, David Miller (davem@davemloft.net) wrote:
> > The panic is in __teql_resolve (which has been inlined into teql_master_xmit) in
> > net/sched/sch_teql.c at this line:
> >
> > if (n && n->tbl == mn->tbl &&
> >
> > Specifically the dereference of n->tbl is faulting as n is not valid.
n is never valid (null), mn is garbage.
> > And the address looks like part of an ASCCI string... "figt"
>
> I studied sch_teql.c a bit and I suspect that the slave list
> management in teql_destroy() and teql_qdisc_init() might be
> suspect.
tecl_reset() is called from deactivate and qdisc is set to noop already,
but subsequent teql_xmit does not know about it and dereference private
data as teql qdisc and thus oopses. I will fix it tomorrow if you will
not catch it first :)
--
Evgeniy Polyakov
next prev parent reply other threads:[~2007-11-05 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 18:00 kernel panic removing devices from a teql queuing discipline Chuck Ebbert
2007-10-30 8:33 ` David Miller
2007-11-05 20:08 ` Evgeniy Polyakov [this message]
2007-11-06 10:48 ` Evgeniy Polyakov
2007-11-06 11:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105200800.GA4075@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=cebbert@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).