From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>, Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH 1/7] sky2: enable PCI config writes
Date: Mon, 05 Nov 2007 15:52:08 -0800 [thread overview]
Message-ID: <20071105235339.973177053@linux-foundation.org> (raw)
In-Reply-To: 20071105235207.799504040@linux-foundation.org
[-- Attachment #1: sky2-enable-pci-config.patch --]
[-- Type: text/plain, Size: 730 bytes --]
On some boards, PCI configuration space access is turned off by default.
The 2.6.24 driver doesn't turn it on, and should have.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
--- a/drivers/net/sky2.c 2007-11-05 10:01:10.000000000 -0800
+++ b/drivers/net/sky2.c 2007-11-05 15:01:44.000000000 -0800
@@ -2791,6 +2791,9 @@ static void sky2_reset(struct sky2_hw *h
sky2_write8(hw, B0_CTST, CS_RST_SET);
sky2_write8(hw, B0_CTST, CS_RST_CLR);
+ /* allow writes to PCI config */
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
+
/* clear PCI errors, if any */
pci_read_config_word(pdev, PCI_STATUS, &status);
status |= PCI_STATUS_ERROR_BITS;
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-11-05 23:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 23:52 [PATCH 0/7] sky2: update for 2.6.24-rc2 Stephen Hemminger
2007-11-05 23:52 ` Stephen Hemminger [this message]
2007-11-06 17:41 ` [PATCH 1/7] sky2: enable PCI config writes Jeff Garzik
2007-11-05 23:52 ` [PATCH 2/7] sky2: status ring race fix Stephen Hemminger
2007-11-05 23:52 ` [PATCH 3/7] sky2: longer PHY delay Stephen Hemminger
2007-11-05 23:52 ` [PATCH 4/7] sky2: dont change LED after autoneg Stephen Hemminger
2007-11-05 23:52 ` [PATCH 5/7] sky2: remove unneeded mask update Stephen Hemminger
2007-11-05 23:52 ` [PATCH 6/7] sky2: handle advanced error recovery config issues Stephen Hemminger
2007-11-05 23:52 ` [PATCH 7/7] sky2: version 1.20 Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105235339.973177053@linux-foundation.org \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).