Re: [PATCH 04/05] ipv6: RFC4214 Support

[Stephen Hemminger <shemminger@linux-foundation.org>]

On Wed, 7 Nov 2007 10:41:49 -0800
"Templin, Fred L" <Fred.L.Templin@boeing.com> wrote:

> Yoshifuji, 
> 
> > -----Original Message-----
> > From: YOSHIFUJI Hideaki / 吉藤英明 [mailto:yoshfuji@linux-ipv6.org] 
> > Sent: Wednesday, November 07, 2007 10:37 AM
> > To: Templin, Fred L
> > Cc: netdev@vger.kernel.org; yoshfuji@linux-ipv6.org
> > Subject: Re: [PATCH 04/05] ipv6: RFC4214 Support
> > 
> > Hello.
> > 
> > In article 
> > <39C363776A4E8C4A94691D2BD9D1C9A1029EDBE5@XCH-NW-7V2.nw.nos.bo
> > eing.com> (at Tue, 6 Nov 2007 17:16:11 -0800), "Templin, Fred 
> > L" <Fred.L.Templin@boeing.com> says:
> > 
> > > @@ -154,6 +155,14 @@ static struct ip_tunnel * ipip6_tunnel_l
> > >  	struct net_device *dev;
> > >  	char name[IFNAMSIZ];
> > >  
> > > +#if defined(CONFIG_IPV6_ISATAP)
> > > +	/* ISATAP (RFC4214) - router address in daddr */
> > > +	if (!strncmp(parms->name, "isatap", 6)) {
> > > +		parms->i_key = parms->iph.daddr;
> > > +		parms->iph.daddr = remote = 0;
> > > +	}
> > > +#endif
> > > +
> > >  	for (tp = __ipip6_bucket(parms); (t = *tp) != NULL; tp =
> > > &t->next) {
> > >  		if (local == t->parms.iph.saddr && remote ==
> > > t->parms.iph.daddr)
> > >  			return t;
> > 
> > I do not think it is a good idea to change the behavior based on
> > the interface name.
> 
> The goal was to avoid requiring changes to applications such as
> 'iproute2', i.e., the intention was for a standalone code insertion point
> within the kernel itself. What do you suggest?

Agreed, magic names are evil.

Change iproute2 utilities, if it is more logical for administration.


-- 
Stephen Hemminger <shemminger@linux-foundation.org>