* [PATCH] netns: init dev_base_lock only once
@ 2007-11-07 12:51 Alexey Dobriyan
2007-11-11 6:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2007-11-07 12:51 UTC (permalink / raw)
To: davem; +Cc: netdev, devel, ebiederm
* it already statically initialized
* reinitializing live global spinlock every time netns is
setup is also wrong
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
net/core/dev.c | 1 -
1 file changed, 1 deletion(-)
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4330,7 +4330,6 @@ static struct hlist_head *netdev_create_hash(void)
static int __net_init netdev_init(struct net *net)
{
INIT_LIST_HEAD(&net->dev_base_head);
- rwlock_init(&dev_base_lock);
net->dev_name_head = netdev_create_hash();
if (net->dev_name_head == NULL)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netns: init dev_base_lock only once
2007-11-07 12:51 [PATCH] netns: init dev_base_lock only once Alexey Dobriyan
@ 2007-11-11 6:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-11-11 6:09 UTC (permalink / raw)
To: adobriyan; +Cc: netdev, devel, ebiederm
From: Alexey Dobriyan <adobriyan@sw.ru>
Date: Wed, 7 Nov 2007 15:51:33 +0300
> * it already statically initialized
> * reinitializing live global spinlock every time netns is
> setup is also wrong
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Good catch.
Applied, thanks Alexey.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-11 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-07 12:51 [PATCH] netns: init dev_base_lock only once Alexey Dobriyan
2007-11-11 6:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).