From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings': Date: Thu, 8 Nov 2007 04:30:10 +0100 Message-ID: <20071108033010.GF26163@stusta.de> References: <200711012024.57412.toralf.foerster@gmx.de> <200711021230.22588.david-b@pacbell.net> <20071102195517.GW30287@stusta.de> <200711071434.52607.david-b@pacbell.net> <20071107225232.GB26163@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Randy Dunlap , Toralf =?utf-8?Q?F=C3=B6rster?= , linux-kernel@vger.kernel.org, netdev To: David Brownell , David Miller Return-path: Received: from emailhub.stusta.mhn.de ([141.84.69.5]:44271 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753846AbXKHDae (ORCPT ); Wed, 7 Nov 2007 22:30:34 -0500 Content-Disposition: inline In-Reply-To: <20071107225232.GB26163@stusta.de> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote: > On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: > > > > But on the other hand, it seems that only the ASIX code will work > > > > right; the DM9601 and MCS7830 Kconfig is different/wrong. > > > > > > I'm not seeing the problem. > > > > > > Which configuration will be handled wrongly? > > > > Notice how only the ASIX kconfig depended on NET_ETHERNET... > > since MII depends on NET_ETHERNET, and (last I knew) the > > reverse dependencies didn't capture the complete dependency > > tree, selecting only MII would leave out some stuff. > > Except for one s390 net driver (I'll check why it's doing this) the > NET_ETHERNET option does not influence what code is being generated - > it's just a Kconfig-internal option allowing to disable a huge bunch > of drivers at once. Damn, I shouldn't have only grep'ed under drivers/. @davem: Please look at net/ipv4/arp.c:arp_process() Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or CONFIG_NETDEV_10000=y will not be handled correctly there? And the best solution is to nuke all #ifdef's in this function and make the code unconditionally available? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed