netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sky2: netpoll on port 0 only
@ 2007-11-06 19:45 Stephen Hemminger
  2007-11-08 17:47 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2007-11-06 19:45 UTC (permalink / raw)
  To: Jeff Garzik, David S. Miller; +Cc: netdev

Netpoll will only work on port 0 because of the restrictive
relationship between NAPI and netpoll.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

--- a/drivers/net/sky2.c	2007-11-06 09:09:18.000000000 -0800
+++ b/drivers/net/sky2.c	2007-11-06 11:42:48.000000000 -0800
@@ -3995,7 +3995,8 @@ static __devinit struct net_device *sky2
 	dev->tx_timeout = sky2_tx_timeout;
 	dev->watchdog_timeo = TX_WATCHDOG;
 #ifdef CONFIG_NET_POLL_CONTROLLER
-	dev->poll_controller = sky2_netpoll;
+	if (port == 0)
+		dev->poll_controller = sky2_netpoll;
 #endif
 
 	sky2 = netdev_priv(dev);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sky2: netpoll on port 0 only
  2007-11-06 19:45 [PATCH] sky2: netpoll on port 0 only Stephen Hemminger
@ 2007-11-08 17:47 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-11-08 17:47 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: Jeff Garzik, David S. Miller, netdev

On Tue, Nov 06, 2007 at 11:45:40AM -0800, Stephen Hemminger wrote:
> Netpoll will only work on port 0 because of the restrictive
> relationship between NAPI and netpoll.
> 
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

applied



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-08 17:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-06 19:45 [PATCH] sky2: netpoll on port 0 only Stephen Hemminger
2007-11-08 17:47 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).