From: Francois Romieu <romieu@fr.zoreil.com>
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Mark Lord <mlord@pobox.com>,
Ciaran McCreesh <ciaran.mccreesh@blueyonder.co.uk>,
Josh Logan <joshtlogan@gmail.com>, cecco <f.cecco77@tiscali.it>,
Hans-Jurgen Koch <hjk@linutronix.de>,
David Gundersen <gundy@iinet.net.au>,
Will Trives <will@trivescon.com.au>,
"Alexander Y. Fomichev" <gluk@php4.ru>,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
Daniel Drake <dsd@gentoo.org>,
Lennert Buytenhek <buytenh@wantstofly.org>,
Philip Craig <philipc@snapgear.com>,
Edward Hsu <edward_hsu@realtek.com.tw>
Subject: [PATCH 02/05] r8169: do not enable the TBI for the 8168 and the 81x0
Date: Fri, 9 Nov 2007 00:09:36 +0100 [thread overview]
Message-ID: <20071108230936.GC15968@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20071108230734.GA15968@electric-eye.fr.zoreil.com>
The 8168c and the 8100e choke on it. I have not seen an indication
nor received a report that the TBI is being actively used on the
remaining 8168b and 8110. Let's disable it for now until someone
complains.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: Matthias Winkler <m.winkler@unicon-ka.de>
Cc: Maarten Vanraes <maarten.vanraes@gmail.com>
Cc: Edward Hsu <edward_hsu@realtek.com.tw>
---
drivers/net/r8169.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 702334e..9dbab3f 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1741,7 +1741,8 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
tp->features |= rtl_try_msi(pdev, ioaddr, cfg);
RTL_W8(Cfg9346, Cfg9346_Lock);
- if (RTL_R8(PHYstatus) & TBI_Enable) {
+ if ((tp->mac_version <= RTL_GIGA_MAC_VER_06) &&
+ (RTL_R8(PHYstatus) & TBI_Enable)) {
tp->set_speed = rtl8169_set_speed_tbi;
tp->get_settings = rtl8169_gset_tbi;
tp->phy_reset_enable = rtl8169_tbi_reset_enable;
--
1.5.3.3
next prev parent reply other threads:[~2007-11-08 23:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 23:07 [PATCH 00/05] pull request for 'upstream-jeff' branch Francois Romieu
2007-11-08 23:08 ` [PATCH 01/05] r8169: add PCI ID for the 8168 in the Abit Fatal1ty F-190HD motherboard Francois Romieu
2007-11-08 23:09 ` Francois Romieu [this message]
2007-11-08 23:10 ` [PATCH 03/05] r8169: revert 7da97ec96a0934319c7fbedd3d38baf533e20640 (partly) Francois Romieu
2007-11-08 23:11 ` [PATCH 04/05] r8169: revert 7da97ec96a0934319c7fbedd3d38baf533e20640 (bis repetita) Francois Romieu
2007-11-08 23:12 ` [PATCH 05/05] r8169: prevent bit sign expansion error in mdio_write Francois Romieu
2007-11-10 5:33 ` [PATCH 00/05] pull request for 'upstream-jeff' branch Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071108230936.GC15968@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@linux-foundation.org \
--cc=buytenh@wantstofly.org \
--cc=ciaran.mccreesh@blueyonder.co.uk \
--cc=dsd@gentoo.org \
--cc=edward_hsu@realtek.com.tw \
--cc=eike-kernel@sf-tec.de \
--cc=f.cecco77@tiscali.it \
--cc=gluk@php4.ru \
--cc=gundy@iinet.net.au \
--cc=hjk@linutronix.de \
--cc=jgarzik@pobox.com \
--cc=joshtlogan@gmail.com \
--cc=mlord@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=philipc@snapgear.com \
--cc=will@trivescon.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).