From: Ingo Oeser <netdev@axxeo.de>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>,
Jeff Garzik <jeff@garzik.org>,
e1000-devel@lists.sourceforge.net,
NetDev <netdev@vger.kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
john.ronciak@intel.com, jeffrey.t.kirsher@intel.com,
'Stephen Hemminger' <shemminger@linux-foundation.org>,
wenxiong@us.ibm.com
Subject: Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery
Date: Fri, 9 Nov 2007 18:02:34 +0100 [thread overview]
Message-ID: <200711091802.36365.netdev@axxeo.de> (raw)
In-Reply-To: <20071107232119.GQ4239@austin.ibm.com>
Hi Linas,
Linas Vepstas schrieb:
> Index: linux-2.6.23-rc8-mm1/include/linux/netdevice.h
> ===================================================================
> --- linux-2.6.23-rc8-mm1.orig/include/linux/netdevice.h 2007-09-26 15:07:05.000000000 -0500
> +++ linux-2.6.23-rc8-mm1/include/linux/netdevice.h 2007-11-07 17:14:50.000000000 -0600
> @@ -384,6 +384,18 @@ static inline void napi_enable(struct na
> clear_bit(NAPI_STATE_SCHED, &n->state);
> }
>
> +/**
> + * napi_enabled_p - return non-zero if napi enabled
> + * @n: napi context
> + *
> + * Mnemonic: _p stands for "predicate", returning a yes/no
> + * answer to the question.
Call it "is_napi_enabled()" an nobody will ask :-)
> + */
> +static inline int napi_enabled_p(struct napi_struct *n)
And please make it return "bool" instead of "int".
Best Regards
Ingo Oeser
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-11-09 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071107211935.GH4239@austin.ibm.com>
[not found] ` <20071107212404.GA15251@austin.ibm.com>
[not found] ` <47323319.10709@intel.com>
[not found] ` <20071107222446.GM4239@austin.ibm.com>
2007-11-07 22:45 ` [PATCH 2/2]: e1000: avoid lockup durig error recovery Kok, Auke
2007-11-07 23:21 ` Linas Vepstas
2007-11-09 17:02 ` Ingo Oeser [this message]
2007-11-09 22:40 ` Linas Vepstas
2007-11-10 16:55 ` Stephen Hemminger
2007-11-08 1:15 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711091802.36365.netdev@axxeo.de \
--to=netdev@axxeo.de \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linas@austin.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).