From: Ingo Oeser <netdev@axxeo.de>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: Fred.L.Templin@boeing.com, netdev@vger.kernel.org
Subject: Re: [PATCH 02/05] ipv6: RFC4214 Support
Date: Fri, 9 Nov 2007 19:12:02 +0100 [thread overview]
Message-ID: <200711091912.03419.netdev@axxeo.de> (raw)
In-Reply-To: <20071108.044745.123583545.yoshfuji@linux-ipv6.org>
YOSHIFUJI Hideaki / 吉藤英明 schrieb:
> In article <39C363776A4E8C4A94691D2BD9D1C9A1029EDBF4@XCH-NW-7V2.nw.nos.boeing.com> (at Wed, 7 Nov 2007 10:52:47 -0800), "Templin, Fred L" <Fred.L.Templin@boeing.com> says:
>
> > > > > > > + if (((ipv4 >= 0x01000000) && (ipv4 < 0x0a000000)) ||
> > > > > > > + ((ipv4 >= 0x0b000000) && (ipv4 < 0x7f000000)) ||
> > > > > > > + ((ipv4 >= 0x80000000) && (ipv4 < 0xa9fe0000)) ||
> > > > > > > + ((ipv4 >= 0xa9ff0000) && (ipv4 < 0xac100000)) ||
> > > > > > > + ((ipv4 >= 0xac200000) && (ipv4 < 0xc0a80000)) ||
> > > > > > > + ((ipv4 >= 0xc0a90000) && (ipv4 < 0xc6120000)) ||
> > > > > > > + ((ipv4 >= 0xc6140000) && (ipv4 <
> > > 0xe0000000))) eui[0] |=
> > > > > > > 0x2;
>
> > Maybe it is I who did not understand. Can you suggest a clean solution?
>
> You could write each element as LOOPBACK(), MULTICAST()
> etc.
> eui[0] = (!ZERONETO(a) &&
> !PRIVATE_10(a) &&
> !LINKLOCAL(a) &&
> !PRIVATE_172(a) &&
> !PRIVATE_192(a) &&
> !NETICDEVBENCH(a) &&
> !MULTICAST(a)) ? 2 : 0;
Oh, yes that's great! Now even *I* can read what this is all about
without reading any RFC :-)
Please Fred, try to do it that way.
Best Regards
Ingo Oeser
prev parent reply other threads:[~2007-11-09 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 1:16 [PATCH 02/05] ipv6: RFC4214 Support Templin, Fred L
2007-11-07 15:58 ` Ingo Oeser
2007-11-07 16:12 ` Templin, Fred L
2007-11-07 18:12 ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-07 18:24 ` Templin, Fred L
2007-11-07 18:48 ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-07 18:52 ` Templin, Fred L
2007-11-07 19:01 ` Simon Arlott
2007-11-07 19:32 ` Templin, Fred L
2007-11-07 19:38 ` Simon Arlott
2007-11-07 19:47 ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-09 18:12 ` Ingo Oeser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711091912.03419.netdev@axxeo.de \
--to=netdev@axxeo.de \
--cc=Fred.L.Templin@boeing.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).