From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] [TCP]: Fix reord detection due to snd_una covered holes
Date: Sat, 10 Nov 2007 21:22:40 -0800 (PST) [thread overview]
Message-ID: <20071110.212240.31482289.davem@davemloft.net> (raw)
In-Reply-To: <11946921621074-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Sat, 10 Nov 2007 12:56:00 +0200
> Fixes subtle bug like the one with fastpath_cnt_hint happening
> due to the way the GSO and hints interact. Because hints are not
> reset when just a GSOed skb is partially ACKed, there's no
> guarantee that the relevant part of the write queue is going to
> be processed in sacktag at all (skbs below snd_una) because
> fastpath hint can fast forward the entrypoint.
>
> This was also on the way of future reductions in sacktag's skb
> processing. Also future cleanups in sacktag can be made after
> this (in 2.6.25).
>
> This may make reordering update in tcp_try_undo_partial
> redundant but I'm not too sure so I left it there.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Thanks for discovering this.
Applied, thanks.
next prev parent reply other threads:[~2007-11-11 5:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 10:55 [PATCH net-2.6 0/4] [TCP]: Bug fixes & minor tweaks Ilpo Järvinen
2007-11-10 10:55 ` [PATCH 1/4] [TCP]: Consider GSO while counting reord in sacktag Ilpo Järvinen
2007-11-10 10:56 ` [PATCH 2/4] [TCP]: Fix reord detection due to snd_una covered holes Ilpo Järvinen
2007-11-10 10:56 ` [PATCH 3/4] [TCP]: Add unlikely() to sacktag out-of-mem in fragment case Ilpo Järvinen
2007-11-10 10:56 ` [PATCH 4/4] [TCP]: Split SACK FRTO flag clearing (fixes FRTO corner case bug) Ilpo Järvinen
2007-11-11 5:24 ` David Miller
2007-11-11 5:23 ` [PATCH 3/4] [TCP]: Add unlikely() to sacktag out-of-mem in fragment case David Miller
2007-11-11 5:22 ` David Miller [this message]
2007-11-11 5:21 ` [PATCH 1/4] [TCP]: Consider GSO while counting reord in sacktag David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071110.212240.31482289.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).