From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH 2/4] Add missed tunnel64_err handler
Date: Sat, 10 Nov 2007 21:48:24 -0800 (PST) [thread overview]
Message-ID: <20071110.214824.32316967.davem@davemloft.net> (raw)
In-Reply-To: <47345D24.7010603@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 09 Nov 2007 16:14:12 +0300
> The tunnel64_protocol uses the tunnel4_protocol's err_handler and
> thus calls the tunnel4_protocol's handlers.
>
> This is not very good, as in case of (icmp) error the wrong error
> handlers will be called (e.g. ipip ones instead of sit) and this
> won't be noticed at all, because the error is not reported.
>
> Was that made deliberately and I miss something?
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
This definitely was doing the wrong thing for the SIT
case, for example. So this looks legitimate to me.
Patch applied, thanks!
prev parent reply other threads:[~2007-11-11 5:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 13:14 [PATCH 2/4] Add missed tunnel64_err handler Pavel Emelyanov
2007-11-11 5:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071110.214824.32316967.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).