Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: chuck.lever@oracle.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] NET: Fix skb_truesize_check() assertion
Date: Sat, 10 Nov 2007 21:53:45 -0800 (PST)	[thread overview]
Message-ID: <20071110.215345.02573115.davem@davemloft.net> (raw)
In-Reply-To: <20071108165919.14014.56630.stgit@manray.1015granger.net>

From: Chuck Lever <chuck.lever@oracle.com>
Date: Thu, 08 Nov 2007 11:59:19 -0500

> The intent of the assertion in skb_truesize_check() is to check
> for skb->truesize being decremented too much by other code,
> resulting in a wraparound below zero.
> 
> The type of the right side of the comparison causes the compiler to
> promote the left side to an unsigned type, despite the presence of an
> explicit type cast.  This defeats the check for negativity.
> 
> Ensure both sides of the comparison are a signed type to prevent the
> implicit type conversion.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

Applied, thanks Chuck.

      reply	other threads:[~2007-11-11  5:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08 16:59 [PATCH] NET: Fix skb_truesize_check() assertion Chuck Lever
2007-11-11  5:53 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071110.215345.02573115.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chuck.lever@oracle.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox