From: Simon Horman <horms@verge.net.au>
To: Adrian Bunk <bunk@kernel.org>
Cc: "Rumen G. Bogdanovski" <rumen@voicecho.com>,
wensong@linux-vs.org, ja@ssi.bg, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
LVS Development mailing list <lvs-devel@linuxvirtualserver.org>
Subject: Re: [2.6 patch] net/ipv4/ipvs/: remove unused exports
Date: Sun, 11 Nov 2007 16:09:40 +0900 [thread overview]
Message-ID: <20071111070939.GA25304@verge.net.au> (raw)
In-Reply-To: <20071111064840.GJ21669@stusta.de>
On Sun, Nov 11, 2007 at 07:48:40AM +0100, Adrian Bunk wrote:
> This patch removes the following unused EXPORT_SYMBOL's:
> - ip_vs_try_bind_dest
> - ip_vs_find_dest
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Looks fine to me.
Should Dave Miller put this in his tree,
or do you want to handle it a different way?
Acked-by: Simon Horman <horms@verge.net.au>
>
> ---
>
> net/ipv4/ipvs/ip_vs_conn.c | 1 -
> net/ipv4/ipvs/ip_vs_ctl.c | 1 -
> 2 files changed, 2 deletions(-)
>
> ad9f400d4f66ea3423f97e609d6ef2572055c603
> diff --git a/net/ipv4/ipvs/ip_vs_conn.c b/net/ipv4/ipvs/ip_vs_conn.c
> index b7eeae6..0a9f3c3 100644
> --- a/net/ipv4/ipvs/ip_vs_conn.c
> +++ b/net/ipv4/ipvs/ip_vs_conn.c
> @@ -441,7 +441,6 @@ struct ip_vs_dest *ip_vs_try_bind_dest(struct ip_vs_conn *cp)
> } else
> return NULL;
> }
> -EXPORT_SYMBOL(ip_vs_try_bind_dest);
>
>
> /*
> diff --git a/net/ipv4/ipvs/ip_vs_ctl.c b/net/ipv4/ipvs/ip_vs_ctl.c
> index 3c4d22a..b64cf45 100644
> --- a/net/ipv4/ipvs/ip_vs_ctl.c
> +++ b/net/ipv4/ipvs/ip_vs_ctl.c
> @@ -604,7 +604,6 @@ struct ip_vs_dest *ip_vs_find_dest(__be32 daddr, __be16 dport,
> ip_vs_service_put(svc);
> return dest;
> }
> -EXPORT_SYMBOL(ip_vs_find_dest);
>
> /*
> * Lookup dest by {svc,addr,port} in the destination trash.
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
next prev parent reply other threads:[~2007-11-11 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 6:48 [2.6 patch] net/ipv4/ipvs/: remove unused exports Adrian Bunk
2007-11-11 7:09 ` Simon Horman [this message]
2007-11-12 7:58 ` Adrian Bunk
2007-11-12 8:01 ` David Miller
2007-11-13 5:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071111070939.GA25304@verge.net.au \
--to=horms@verge.net.au \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@linuxvirtualserver.org \
--cc=netdev@vger.kernel.org \
--cc=rumen@voicecho.com \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).