From: Mark Fasheh <mark.fasheh@oracle.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: netdev@vger.kernel.org,
Paul Clements <Paul.Clements@steeleye.com>,
Steve French <sfrench@samba.org>,
David Howells <dhowells@redhat.com>,
David S Miller <davem@davemloft.net>
Subject: Re: [PATCH] NET: Add the helper kernel_sock_shutdown()
Date: Sun, 11 Nov 2007 10:03:41 -0800 [thread overview]
Message-ID: <20071111180341.GP28607@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20071109000136.4700.8891.stgit@heimdal.trondhjem.org>
On Thu, Nov 08, 2007 at 07:01:36PM -0500, Trond Myklebust wrote:
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
>
> ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers.
>
> Looking at the sock->op->shutdown() handlers, it looks as if all of them
> take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the
> RCV_SHUTDOWN/SEND_SHUTDOWN arguments.
> Add a helper, and then define the SHUT_* enum to ensure that kernel users
> of shutdown() don't get confused.
That looks pretty good - any objection to naming the enum and using that
name in the prototype for kernel_sock_shutdown() so it's even more obvious
what type of shutdown argument this expects?
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
next prev parent reply other threads:[~2007-11-11 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071109000136.4700.8891.stgit@heimdal.trondhjem.org>
2007-11-09 1:44 ` [PATCH] NET: Add the helper kernel_sock_shutdown() David Howells
2007-11-11 18:03 ` Mark Fasheh [this message]
2007-11-11 18:40 ` Trond Myklebust
2007-11-11 20:45 ` Mark Fasheh
2007-11-12 12:22 ` David Howells
2007-11-12 13:33 ` Trond Myklebust
2007-11-12 14:31 ` David Howells
2007-11-09 1:01 Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071111180341.GP28607@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=Paul.Clements@steeleye.com \
--cc=Trond.Myklebust@netapp.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).