From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: johannes@sipsolutions.net, netdev@vger.kernel.org,
linuxppc-dev@ozlabs.org, shemminger@linux-foundation.org
Subject: Re: [PATCH] sungem: fix suspend regression due to NAPI changes
Date: Mon, 12 Nov 2007 18:09:46 -0800 (PST) [thread overview]
Message-ID: <20071112.180946.150182058.davem@davemloft.net> (raw)
In-Reply-To: <1194906766.18185.79.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Tue, 13 Nov 2007 09:32:46 +1100
>
> On Mon, 2007-11-12 at 18:45 +0100, Johannes Berg wrote:
> > Commit bea3348e (the NAPI changes) made sungem unconditionally enable
> > NAPI when resuming and unconditionally disable when suspending, this,
> > however, makes napi_disable() hang when suspending when the interface
> > was taken down before suspend because taking the interface down also
> > disables NAPI. This patch makes touching the napi struct in
> > suspend/resume code paths depend on having the interface up, thereby
> > fixing the hang on suspend.
> >
> > The patch also moves the napi_disable() in gem_close() under the lock so
> > that the NAPI state is always modified atomically together with the
> > "opened" variable.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
> Thanks for fixing that !
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Indeed, thanks a lot Johannes.
Patch applied.
prev parent reply other threads:[~2007-11-13 2:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 17:45 [PATCH] sungem: fix suspend regression due to NAPI changes Johannes Berg
2007-11-12 22:32 ` Benjamin Herrenschmidt
2007-11-13 2:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071112.180946.150182058.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).