From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: netdev@vger.kernel.org, andy@greyhouse.net, mchan@broadcom.com
Subject: Re: [PATCH 1/13] tg3: Fix 5761 PXEboot crash
Date: Mon, 12 Nov 2007 21:07:13 -0800 (PST) [thread overview]
Message-ID: <20071112.210713.95371045.davem@davemloft.net> (raw)
In-Reply-To: <1194655117.5745.263.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:37 -0800
> When 5761 devices boot the machine using PXEboot, PXE leaves the device
> active when it terminates. The tg3 driver has code to detect this
> condition and resets the device during initialization. On 5761 devices,
> device resets involve sending a driver state update message to the APE
> on the 5761. However, during this initialization stage, communications
> to the APE registers have not yet been set up. The driver then
> dereferences a NULL pointer and crashes the machine. The fix is to move
> the APE register access setup earlier in the initialization code to
> cover this condition.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied.
prev parent reply other threads:[~2007-11-13 5:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 0:38 [PATCH 1/13] tg3: Fix 5761 PXEboot crash Matt Carlson
2007-11-13 5:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071112.210713.95371045.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).