From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH][NET] Convert init_timer into setup_timer
Date: Tue, 13 Nov 2007 05:34:21 -0800 (PST) [thread overview]
Message-ID: <20071113.053421.68786227.davem@davemloft.net> (raw)
In-Reply-To: <4739A22B.20600@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 13 Nov 2007 16:10:03 +0300
> Many-many code in the kernel initialized the timer->function
> and timer->data together with calling init_timer(timer). There
> is already a helper for this. Use it for networking code.
>
> The patch is HUGE, but makes the code 130 lines shorter
> (98 insertions(+), 228 deletions(-)).
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
I have no objection to this patch, but it is 2.6.25
material for sure.
next prev parent reply other threads:[~2007-11-13 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 13:10 [PATCH][NET] Convert init_timer into setup_timer Pavel Emelyanov
2007-11-13 13:34 ` David Miller [this message]
2007-11-13 13:43 ` Arnaldo Carvalho de Melo
2007-11-13 14:02 ` Pavel Emelyanov
2007-11-14 5:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113.053421.68786227.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).