netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nickpiggin@yahoo.com.au
Cc: clameter@sgi.com, netdev@vger.kernel.org,
	herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org
Subject: Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench
Date: Tue, 13 Nov 2007 17:58:04 -0800 (PST)	[thread overview]
Message-ID: <20071113.175804.151698768.davem@davemloft.net> (raw)
In-Reply-To: <200711132241.59074.nickpiggin@yahoo.com.au>

From: Nick Piggin <nickpiggin@yahoo.com.au>
Date: Tue, 13 Nov 2007 22:41:58 +1100

> On Tuesday 13 November 2007 06:44, Christoph Lameter wrote:
> > On Sat, 10 Nov 2007, Nick Piggin wrote:
> > > BTW. your size-2048 kmalloc cache is order-1 in the default setup,
> > > wheras kmalloc(1024) or kmalloc(4096) will be order-0 allocations. And
> > > SLAB also uses order-0 for size-2048. It would be nice if SLUB did the
> > > same...
> >
> > You can try to see the effect that order 0 would have by booting with
> >
> > slub_max_order=0
> 
> Yeah, that didn't help much, but in general I think it would give
> more consistent and reliable behaviour from slub.

Just a note that I'm not ignoring this issue, I just don't have time
to get to it yet.

I suspect the issue is about having a huge skb->data linear area for
TCP sends over loopback.  We're likely getting a much smaller
skb->data linear data area after the patch in question, the rest using
the sk_buff scatterlist pages which are a little bit more expensive to
process.

  reply	other threads:[~2007-11-14  1:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200711092336.56172.nickpiggin@yahoo.com.au>
     [not found] ` <Pine.LNX.4.64.0711091533300.17621@schroedinger.engr.sgi.com>
     [not found]   ` <200711101229.35822.nickpiggin@yahoo.com.au>
2007-11-10  3:28     ` 2.6.24-rc2: Network commit causes SLUB performance regression with tbench Nick Piggin
     [not found]     ` <Pine.LNX.4.64.0711121144001.26936@schroedinger.engr.sgi.com>
2007-11-13 11:41       ` Nick Piggin
2007-11-14  1:58         ` David Miller [this message]
2007-11-13 17:36           ` Nick Piggin
2007-11-14  6:12             ` David Miller
2007-11-13 18:14               ` Nick Piggin
2007-11-14  6:37                 ` David Miller
2007-11-13 22:27                   ` Nick Piggin
2007-11-13 22:55                     ` Nick Piggin
2007-11-14 11:10                     ` David Miller
2007-11-13 23:39                       ` Nick Piggin
2007-11-14 11:48                       ` Herbert Xu
2007-11-14  0:02                         ` Nick Piggin
2007-11-14 12:10                           ` David Miller
2007-11-14 18:33                             ` Christoph Lameter
2007-11-14 23:46                         ` David Miller
2007-11-15  0:21                           ` Nick Piggin
2007-11-15  0:27                             ` David Miller
2007-11-15  1:03                           ` Christoph Lameter
2007-11-15  1:11                             ` Herbert Xu
2007-11-15  1:47                               ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071113.175804.151698768.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=clameter@sgi.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).