From: David Miller <davem@davemloft.net>
To: wangchen@cn.fujitsu.com
Cc: netdev@vger.kernel.org, dada1@cosmosbay.com
Subject: Re: [PATCH 1/2] SOCK: add raw drops counter
Date: Tue, 13 Nov 2007 20:30:40 -0800 (PST) [thread overview]
Message-ID: <20071113.203040.67290528.davem@davemloft.net> (raw)
In-Reply-To: <473A6792.10405@cn.fujitsu.com>
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Wed, 14 Nov 2007 11:12:18 +0800
> Add raw drops counter for IPv4 in /proc/net/raw .
>
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Applied to net-2.6.25, but your patch a lot of whitespace
problems:
Adds trailing whitespace.
diff:9: * @sk_flags: %SO_LINGER (l_onoff), %SO_BROADCAST, %SO_KEEPALIVE,
Adds trailing whitespace.
diff:19: * @sk_prot_creator: sk_prot of original sock creator (see ipv6_setsockopt,
Adds trailing whitespace.
diff:23: * @sk_err_soft: errors that don't cause failure but are the cause of a
Adds trailing whitespace.
diff:56: atomic_inc(&sk->sk_drops);
warning: 4 lines add whitespace errors.
I fixed it by hand this time, but please fix this yourself before
future submissions.
Thank you.
prev parent reply other threads:[~2007-11-14 4:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 9:57 [PATCH] IPV4: add raw drops counter Wang Chen
2007-11-13 11:11 ` Eric Dumazet
2007-11-14 1:27 ` Wang Chen
2007-11-14 6:00 ` Eric Dumazet
2007-11-14 3:12 ` [PATCH 1/2] SOCK: " Wang Chen
2007-11-14 3:15 ` [PATCH 2/2] SOCK: add raw6 " Wang Chen
2007-11-14 4:31 ` David Miller
2007-11-14 4:50 ` Wang Chen
2007-11-14 5:48 ` Eric Dumazet
2007-11-14 6:45 ` Wang Chen
2007-11-14 4:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113.203040.67290528.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).