From: David Miller <davem@davemloft.net>
To: auke-jan.h.kok@intel.com
Cc: jeff@garzik.org, netdev@vger.kernel.org, jesse.brandeburg@intel.com
Subject: Re: [PATCH 4/6] e1000e: convert register test macros to functions
Date: Tue, 13 Nov 2007 20:54:24 -0800 (PST) [thread overview]
Message-ID: <20071113.205424.71818344.davem@davemloft.net> (raw)
In-Reply-To: <20071113231128.13177.76095.stgit@localhost.localdomain>
From: Auke Kok <auke-jan.h.kok@intel.com>
Date: Tue, 13 Nov 2007 15:11:28 -0800
> From: Joe Perches <joe@perches.com>
>
> Add functions for reg_pattern_test and reg_set_and check
> Changed macros to use these functions
>
> Compiled x86, untested
>
> Size decreased ~2K
>
> old:
>
> $ size drivers/net/e1000e/ethtool.o
> text data bss dec hex filename
> 14461 0 0 14461 387d drivers/net/e1000e/ethtool.o
>
> new:
>
> $ size drivers/net/e1000e/ethtool.o
> text data bss dec hex filename
> 12498 0 0 12498 30d2 drivers/net/e1000e/ethtool.o
>
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Applied to netdev-2.6, but I had to fix up the following
whitespace issues by hand:
Adds trailing whitespace.
diff:28:bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
Adds trailing whitespace.
diff:33: static const u32 test[] =
warning: 2 lines add whitespace errors.
Please correct this before submission in the future.
Thanks!
next prev parent reply other threads:[~2007-11-14 4:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 23:11 [PATCH 1/6] e1000e: update netstats traffic counters realtime Auke Kok
2007-11-13 23:11 ` [PATCH 2/6] e1000: " Auke Kok
2007-11-14 4:51 ` David Miller
2007-11-13 23:11 ` [PATCH 3/6] e1000: convert regtest macro's to functions Auke Kok
2007-11-14 4:52 ` David Miller
2007-11-13 23:11 ` [PATCH 4/6] e1000e: convert register test macros " Auke Kok
2007-11-14 4:54 ` David Miller [this message]
2007-11-13 23:11 ` [PATCH 5/6] e1000: Secondary unicast address support Auke Kok
2007-11-14 0:16 ` Krzysztof Oledzki
2007-11-14 0:18 ` Ben Greear
2007-11-14 0:48 ` Krzysztof Oledzki
2007-11-14 1:05 ` Ben Greear
2007-11-14 1:17 ` Krzysztof Oledzki
2007-11-14 4:55 ` David Miller
2007-11-13 23:11 ` [PATCH 6/6] e1000: fix schedule while atomic when called from mii-tool Auke Kok
2007-11-14 5:00 ` David Miller
2007-11-14 4:48 ` [PATCH 1/6] e1000e: update netstats traffic counters realtime David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113.205424.71818344.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=auke-jan.h.kok@intel.com \
--cc=jeff@garzik.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).