Netdev List
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Joonwoo Park" <joonwpark81@gmail.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	'Dave Johnson' <djohnson+linux-kernel@sw.starentnetworks.com>,
	'David Miller' <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
Date: Tue, 13 Nov 2007 12:43:26 -0800	[thread overview]
Message-ID: <20071113124326.51c3607c@freepuppy.rosehill> (raw)
In-Reply-To: <47365200.0f10240a.0686.2173@mx.google.com>

On Sun, 11 Nov 2007 09:51:20 +0900
"Joonwoo Park" <joonwpark81@gmail.com> wrote:

> IMHO even though netdevice is in the promiscuous mode, we should receive all of ingress packets.
> This disable the vlan filtering feature when a vlan hw accel configured e1000 device goes into promiscuous mode.
> This make packets visible to sniffers though it's not vlan id of itself.
> Any check, comments will be appreciated.
> Thanks.
> 
> Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>

Promiscuous has other uses such as bridging. Would this patch break any
existing users startup scripts?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  parent reply	other threads:[~2007-11-13 20:43 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-11  0:51 [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode Joonwoo Park
2007-11-12 17:12 ` Kok, Auke
2007-11-12 17:21   ` Patrick McHardy
2007-11-12 18:01     ` Kok, Auke
2007-11-12 22:33     ` David Miller
2007-11-12 22:43       ` Chris Friesen
2007-11-12 22:54         ` Kok, Auke
2007-11-14 11:48           ` Benny Amorsen
2007-11-12 22:57         ` David Miller
2007-11-12 23:15           ` Willy Tarreau
2007-11-12 23:19             ` David Miller
2007-11-12 23:32               ` Willy Tarreau
2007-11-12 23:38                 ` Kok, Auke
2007-11-12 23:40                 ` David Miller
2007-11-13  1:21                   ` Joonwoo Park
2007-11-13 10:21                     ` Patrick McHardy
2007-11-13 11:09                       ` Herbert Xu
2007-11-13 11:36                         ` David Miller
2007-11-13 12:03                           ` Herbert Xu
2007-11-13 12:06                             ` David Miller
2007-11-13 12:16                               ` Herbert Xu
2007-11-13 12:18                                 ` Patrick McHardy
2007-11-13 16:41                                   ` Kok, Auke
2007-11-13 17:26                                     ` Patrick McHardy
2007-11-13 17:30                                       ` Kok, Auke
2007-11-14  9:42                                         ` Patrick McHardy
2007-11-14 23:30                                           ` Kok, Auke
2007-11-13 19:59                                       ` Kok, Auke
2007-11-13 12:32                                 ` David Miller
2007-11-13  1:21             ` Joonwoo Park
2007-11-12 22:28   ` David Miller
2007-11-13 20:43 ` Stephen Hemminger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-11-14  4:47 Joonwoo Park
2007-11-14  5:12 ` Kok, Auke
2007-11-14  6:15   ` Joonwoo Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071113124326.51c3607c@freepuppy.rosehill \
    --to=shemminger@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=djohnson+linux-kernel@sw.starentnetworks.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=joonwpark81@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox