netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] [IPSEC]: Add async resume support on input
Date: Wed, 14 Nov 2007 01:58:12 -0800 (PST)	[thread overview]
Message-ID: <20071114.015812.77787863.davem@davemloft.net> (raw)
In-Reply-To: <20071114063657.GA11293@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 14 Nov 2007 14:36:58 +0800

> On Tue, Nov 13, 2007 at 10:33:56PM -0800, David Miller wrote:
> >
> > Also applied to net-2.6.25, thanks.
> > 
> > I'll work on integrating Patrick's NF_INET_* patch next.
> 
> Thanks! With that you would be able to remove the nf_post_routing
> field from xfrm_state_afinfo.

Done, and checked into net-2.6.25:

>From d15f51674f6e9985c84f221a7fd1026eafbe42c8 Mon Sep 17 00:00:00 2001
From: David S. Miller <davem@sunset.davemloft.net>
Date: Wed, 14 Nov 2007 01:57:47 -0800
Subject: [PATCH] [IPSEC]: Kill afinfo->nf_post_routing

After changeset:

	[NETFILTER]: Introduce NF_INET_ hook values

It always evaluates to NF_INET_POST_ROUTING.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/net/xfrm.h     |    1 -
 net/ipv4/xfrm4_state.c |    1 -
 net/ipv6/xfrm6_state.c |    1 -
 net/xfrm/xfrm_output.c |    2 +-
 4 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index e184c11..99251b7 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -259,7 +259,6 @@ struct xfrm_state_afinfo {
 	unsigned int		family;
 	unsigned int		proto;
 	unsigned int		eth_proto;
-	unsigned int		nf_post_routing;
 	struct module		*owner;
 	struct xfrm_type	*type_map[IPPROTO_MAX];
 	struct xfrm_mode	*mode_map[XFRM_MODE_MAX];
diff --git a/net/ipv4/xfrm4_state.c b/net/ipv4/xfrm4_state.c
index 2961135..fdeebe6 100644
--- a/net/ipv4/xfrm4_state.c
+++ b/net/ipv4/xfrm4_state.c
@@ -66,7 +66,6 @@ static struct xfrm_state_afinfo xfrm4_state_afinfo = {
 	.family			= AF_INET,
 	.proto			= IPPROTO_IPIP,
 	.eth_proto		= htons(ETH_P_IP),
-	.nf_post_routing	= NF_INET_POST_ROUTING,
 	.owner			= THIS_MODULE,
 	.init_flags		= xfrm4_init_flags,
 	.init_tempsel		= __xfrm4_init_tempsel,
diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
index 29e0d25..a7a7e8f 100644
--- a/net/ipv6/xfrm6_state.c
+++ b/net/ipv6/xfrm6_state.c
@@ -188,7 +188,6 @@ static struct xfrm_state_afinfo xfrm6_state_afinfo = {
 	.family			= AF_INET6,
 	.proto			= IPPROTO_IPV6,
 	.eth_proto		= htons(ETH_P_IPV6),
-	.nf_post_routing	= NF_INET_POST_ROUTING,
 	.owner			= THIS_MODULE,
 	.init_tempsel		= __xfrm6_init_tempsel,
 	.tmpl_sort		= __xfrm6_tmpl_sort,
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
index 048d240..3c277a4 100644
--- a/net/xfrm/xfrm_output.c
+++ b/net/xfrm/xfrm_output.c
@@ -113,7 +113,7 @@ int xfrm_output_resume(struct sk_buff *skb, int err)
 			return dst_output(skb);
 
 		err = nf_hook(x->inner_mode->afinfo->family,
-			      x->inner_mode->afinfo->nf_post_routing, skb,
+			      NF_INET_POST_ROUTING, skb,
 			      NULL, skb->dst->dev, xfrm_output2);
 		if (unlikely(err != 1))
 			goto out;
-- 
1.5.3.5


  parent reply	other threads:[~2007-11-14  9:58 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 14:07 [0/24] Merge IPv4/IPv6 IPsec bundle creation and input/ouput Herbert Xu
2007-11-07 14:08 ` [PATCH 1/24] [IPV6]: Only set nfheader_len for top xfrm dst Herbert Xu
2007-11-14  5:32   ` David Miller
2007-11-07 14:08 ` [PATCH 2/24] [IPSEC]: Use dst->header_len when resizing on output Herbert Xu
2007-11-14  5:33   ` David Miller
2007-11-07 14:08 ` [PATCH 3/24] [IPV6]: Move nfheader_len into rt6_info Herbert Xu
2007-11-14  5:33   ` David Miller
2007-11-07 14:08 ` [PATCH 4/24] [NET]: Eliminate duplicate copies of dst_discard Herbert Xu
2007-11-14  5:34   ` David Miller
2007-11-07 14:08 ` [PATCH 5/24] [NET]: Remove unnecessary inclusion of dst.h Herbert Xu
2007-11-14  5:34   ` David Miller
2007-11-07 14:08 ` [PATCH 6/24] [IPSEC]: Only set neighbour on top xfrm dst Herbert Xu
2007-11-14  5:35   ` David Miller
2007-11-07 14:08 ` [PATCH 7/24] [IPSEC]: Set dst->input to dst_discard Herbert Xu
2007-11-14  5:35   ` David Miller
2007-11-07 14:08 ` [PATCH 8/24] [IPSEC]: Make sure idev is consistent with dev in xfrm_dst Herbert Xu
2007-11-14  5:36   ` David Miller
2007-11-07 14:08 ` [PATCH 9/24] [IPSEC]: Replace x->type->{local,remote}_addr with flags Herbert Xu
2007-11-14  5:37   ` David Miller
2007-11-07 14:08 ` [PATCH 10/24] [IPSEC]: Move flow construction into xfrm_dst_lookup Herbert Xu
2007-11-14  5:37   ` David Miller
2007-11-07 14:08 ` [PATCH 11/24] [IPSEC]: Merge common code into xfrm_bundle_create Herbert Xu
2007-11-14  5:38   ` David Miller
2007-11-07 14:08 ` [PATCH 12/24] [IPSEC]: Forbid BEET + ipcomp for now Herbert Xu
2007-11-14  5:39   ` David Miller
2007-11-07 14:08 ` [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section Herbert Xu
2007-11-07 16:17   ` Ingo Oeser
2007-11-08  0:39     ` Herbert Xu
2007-11-13 11:33       ` David Miller
2007-11-13 11:51         ` Herbert Xu
2007-11-14  5:47           ` David Miller
2007-11-14  5:39   ` David Miller
2007-11-07 14:08 ` [PATCH 14/24] [INET]: Give outer DSCP directly to ip*_copy_dscp Herbert Xu
2007-11-14  5:40   ` David Miller
2007-11-07 14:08 ` [PATCH 15/24] [IPSEC]: Separate inner/outer mode processing on output Herbert Xu
2007-11-14  5:41   ` David Miller
2007-11-07 14:08 ` [PATCH 16/24] [IPSEC]: Separate inner/outer mode processing on input Herbert Xu
2007-11-14  5:41   ` David Miller
2007-11-07 14:08 ` [PATCH 17/24] [IPV4]: Add ip_local_out Herbert Xu
2007-11-14  5:42   ` David Miller
2007-11-07 14:08 ` [PATCH 18/24] [IPV6]: Add ip6_local_out Herbert Xu
2007-11-14  5:42   ` David Miller
2007-11-07 14:08 ` [PATCH 19/24] [IPSEC]: Merge most of the output path Herbert Xu
2007-11-08 11:23   ` Patrick McHardy
2007-11-08 11:29     ` Herbert Xu
2007-11-14  9:07       ` David Miller
2007-11-14  9:14         ` Patrick McHardy
2007-11-14  9:16           ` Herbert Xu
2007-11-14  9:19             ` Patrick McHardy
2007-11-14  5:43   ` David Miller
2007-11-07 14:08 ` [PATCH 20/24] [IPSEC]: Add async resume support on output Herbert Xu
2007-11-14  5:44   ` David Miller
2007-11-07 14:08 ` [PATCH 21/24] [IPSEC]: Merge most of the input path Herbert Xu
2007-11-14  5:44   ` David Miller
2007-11-07 14:08 ` [PATCH 22/24] [IPSEC]: Store xfrm states in security path directly Herbert Xu
2007-11-14  5:45   ` David Miller
2007-11-07 14:08 ` [PATCH 23/24] [IPSEC]: Move integrity stat collection into xfrm_input Herbert Xu
2007-11-14  5:45   ` David Miller
2007-11-07 14:08 ` [PATCH 24/24] [IPSEC]: Move state lock into x->type->input Herbert Xu
2007-11-14  5:46   ` David Miller
2007-11-14  6:27     ` [PATCH 1/2] [IPSEC]: Remove nhoff from xfrm_input Herbert Xu
2007-11-14  6:28       ` [PATCH 2/2] [IPSEC]: Add async resume support on input Herbert Xu
2007-11-14  6:33         ` David Miller
2007-11-14  6:36           ` Herbert Xu
2007-11-14  6:38             ` David Miller
2007-11-14  6:41               ` Herbert Xu
2007-11-14  6:46                 ` David Miller
2007-11-14  9:58             ` David Miller [this message]
2007-11-14 10:04               ` Herbert Xu
2007-11-14  9:05           ` Patrick McHardy
2007-11-14  6:32       ` [PATCH 1/2] [IPSEC]: Remove nhoff from xfrm_input David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071114.015812.77787863.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).