From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: guichaz@yahoo.fr, netdev@vger.kernel.org
Subject: Re: Re : Oops preceded by WARNING: at net/ipv4/tcp_input.c:1571 tcp_remove_reno_sacks()
Date: Wed, 14 Nov 2007 15:55:51 -0800 (PST) [thread overview]
Message-ID: <20071114.155551.93961946.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711141245050.23382@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Wed, 14 Nov 2007 15:32:58 +0200 (EET)
> [PATCH] [TCP] FRTO: Clear frto_highmark only after process_frto that uses it
>
> I broke this in commit 3de96471bd7fb76406e975ef6387abe3a0698149.
> tcp_process_frto should always see a valid frto_highmark. An
> invalid frto_highmark (zero) is very likely what ultimately
> caused a seqno compare in tcp_frto_enter_loss to do the wrong
> leading to the LOST-bit leak.
>
> Having LOST-bits integry ensured like done after commit
> 23aeeec365dcf8bc87fae44c533e50d0bb4f23cc won't hurt. It may
> still be useful in some other, possibly legimate, scenario.
>
> Reported by Chazarain Guillaume <guichaz@yahoo.fr>.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied.
Thanks for making such an incredibly thorough investigation
into this bug!
next prev parent reply other threads:[~2007-11-14 23:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 1:39 Re : Oops preceded by WARNING: at net/ipv4/tcp_input.c:1571 tcp_remove_reno_sacks() Chazarain Guillaume
2007-11-11 22:40 ` Ilpo Järvinen
2007-11-13 21:35 ` Ilpo Järvinen
2007-11-14 5:04 ` David Miller
2007-11-14 13:32 ` Ilpo Järvinen
2007-11-14 23:55 ` David Miller [this message]
2007-11-15 8:11 ` Ilpo Järvinen
2007-11-15 10:31 ` Guillaume Chazarain
2007-11-15 11:51 ` Ilpo Järvinen
-- strict thread matches above, loose matches on Subject: below --
2007-11-11 12:53 Chazarain Guillaume
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114.155551.93961946.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=guichaz@yahoo.fr \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox