From: David Miller <davem@davemloft.net>
To: arjan@infradead.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
dada1@cosmosbay.com
Subject: Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()
Date: Thu, 15 Nov 2007 20:07:14 -0800 (PST) [thread overview]
Message-ID: <20071115.200714.109055797.davem@davemloft.net> (raw)
In-Reply-To: <20071115193802.4ec64eef@laptopd505.fenrus.org>
From: Arjan van de Ven <arjan@infradead.org>
Date: Thu, 15 Nov 2007 19:38:02 -0800
> On Thu, 15 Nov 2007 04:01:48 GMT
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
>
> > Using a "if (need_resched())" test before calling
> > "cond_resched();" is necessary to avoid spending too much time doing
> > the resched check.
>
> int __sched cond_resched(void)
> {
> if (need_resched() && .....
>
> somehow I wonder why the second if() is useful at all; it's another
> spot for a branch predictor to miss... and a void function call is
> really really cheap...
Not by Eric's tests. Please read the thread, he checked and it's
50ms more expensive to make the function call.
Please, when you notice something interesting in something flying
by on git-web, go check thing out we probably discussed the thing
you're interested in.
And please at least CC: netdev about networking patches, and also the
patch author, which I've corrected in this reply.
next parent reply other threads:[~2007-11-16 4:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200711150401.lAF41mSs021898@hera.kernel.org>
[not found] ` <20071115193802.4ec64eef@laptopd505.fenrus.org>
2007-11-16 4:07 ` David Miller [this message]
[not found] ` <473D131A.5000200@cosmosbay.com>
[not found] ` <473D18A5.2090309@cosmosbay.com>
2007-11-16 5:59 ` [NET]: rt_check_expire() can take a long time, add a cond_resched() Arjan van de Ven
2007-11-17 12:56 ` Andi Kleen
2007-11-17 15:21 ` Herbert Xu
2007-11-18 0:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115.200714.109055797.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arjan@infradead.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).