* [PATCH] chelsio - Fix skb->dev setting
@ 2007-11-15 11:38 Divy Le Ray
2007-11-15 23:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Divy Le Ray @ 2007-11-15 11:38 UTC (permalink / raw)
To: jeff; +Cc: davem, netdev, linux-kernel
From: Divy Le Ray <divy@chelsio.com>
eth_type_trans() now sets skb->dev.
Access skb->def after it gets set.
Signed-off-by: Divy Le Ray <divy@chelsio.com>
---
drivers/net/chelsio/sge.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/chelsio/sge.c b/drivers/net/chelsio/sge.c
index ffa7e64..4436662 100644
--- a/drivers/net/chelsio/sge.c
+++ b/drivers/net/chelsio/sge.c
@@ -1379,11 +1379,11 @@ static void sge_rx(struct sge *sge, struct freelQ *fl, unsigned int len)
}
__skb_pull(skb, sizeof(*p));
- skb->dev->last_rx = jiffies;
st = per_cpu_ptr(sge->port_stats[p->iff], smp_processor_id());
st->rx_packets++;
skb->protocol = eth_type_trans(skb, adapter->port[p->iff].dev);
+ skb->dev->last_rx = jiffies;
if ((adapter->flags & RX_CSUM_ENABLED) && p->csum == 0xffff &&
skb->protocol == htons(ETH_P_IP) &&
(skb->data[9] == IPPROTO_TCP || skb->data[9] == IPPROTO_UDP)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] chelsio - Fix skb->dev setting
2007-11-15 11:38 [PATCH] chelsio - Fix skb->dev setting Divy Le Ray
@ 2007-11-15 23:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-11-15 23:06 UTC (permalink / raw)
To: divy; +Cc: jeff, netdev, linux-kernel
From: Divy Le Ray <divy@chelsio.com>
Date: Thu, 15 Nov 2007 03:38:57 -0800
> From: Divy Le Ray <divy@chelsio.com>
>
> eth_type_trans() now sets skb->dev.
> Access skb->def after it gets set.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
Patch applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-15 23:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-15 11:38 [PATCH] chelsio - Fix skb->dev setting Divy Le Ray
2007-11-15 23:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).