From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Jonas Danielsson <the.sator@gmail.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
jmorris@namei.org, netdev@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?)
Date: Thu, 15 Nov 2007 18:40:32 +0300 [thread overview]
Message-ID: <20071115154032.GA30391@ms2.inr.ac.ru> (raw)
In-Reply-To: <cac0ab7d0711150340p58eda94ah92894072ba328205@mail.gmail.com>
Hello!
> Send a correct arp reply instead of one with sender ip and sender
> hardware adress in target fields.
I do not see anything more legal in setting target address to 0.
Actually, semantics of target address in ARP reply is ambiguous.
If it is a reply to some real request, it is set to address of requestor
and protocol requires recipient of this arp reply to test that the address
matches its own address before creating new entry triggered by unsolicited
arp reply. That's all.
In the case of duplicate address detection, requestor does not have
any address, so that it is absolutely not essential what we use as target
address. The only place, which could depend on this is the tool, which
tests for duplicate address. At least, arping written by me, should
work with any variant.
So, please, could you explain what did force you to think that use of 0
is better?
Alexey
next prev parent reply other threads:[~2007-11-15 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 11:40 [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?) Jonas Danielsson
2007-11-15 15:40 ` Alexey Kuznetsov [this message]
2007-11-15 21:40 ` Jonas Danielsson
2007-11-15 23:28 ` [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 David Miller
2007-11-16 8:30 ` Jonas Danielsson
2007-11-16 9:05 ` David Miller
2007-11-16 14:13 ` Benny Amorsen
2007-11-16 19:26 ` Bill Fink
2007-11-17 22:14 ` Jarek Poplawski
2007-11-19 13:06 ` [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?) Alexey Kuznetsov
2007-11-20 5:16 ` Bill Fink
2007-11-20 7:49 ` [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115154032.GA30391@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=the.sator@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).