From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: arjan@infradead.org, dada1@cosmosbay.com,
linux-kernel@vger.kernel.org, netdev@vget.kernel.org
Subject: Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()
Date: Sat, 17 Nov 2007 16:03:16 -0800 (PST) [thread overview]
Message-ID: <20071117.160316.162501140.davem@davemloft.net> (raw)
In-Reply-To: <p73k5ohav4n.fsf@bingen.suse.de>
From: Andi Kleen <andi@firstfloor.org>
Date: Sat, 17 Nov 2007 13:56:08 +0100
> Arjan van de Ven <arjan@infradead.org> writes:
> >> >
> >> > Its not that cheap. The ChangeLog included my own numbers, on a
> >> > Pentium M machine. (i686, 1.6 GHz, 1.5 GB ram)
> >> >
> >> > Without "if (need_resched())" (so calling need_resched() X.XXX.XXX
> >> > times), each run takes 88ms
> >> >
> >> > With the extra check (and *much* less function calls), each run
> >> > takes 25ms
>
> ms?!? The numbers sound wrong. Wrong unit?
Read what Eric is saying. He is saying "any entire run" purging
the routing cache takes that long, not just one call.
prev parent reply other threads:[~2007-11-18 0:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200711150401.lAF41mSs021898@hera.kernel.org>
[not found] ` <20071115193802.4ec64eef@laptopd505.fenrus.org>
2007-11-16 4:07 ` [NET]: rt_check_expire() can take a long time, add a cond_resched() David Miller
[not found] ` <473D131A.5000200@cosmosbay.com>
[not found] ` <473D18A5.2090309@cosmosbay.com>
2007-11-16 5:59 ` Arjan van de Ven
2007-11-17 12:56 ` Andi Kleen
2007-11-17 15:21 ` Herbert Xu
2007-11-18 0:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071117.160316.162501140.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vget.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).