netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: wangchen@cn.fujitsu.com, herbert@gondor.apana.org.au,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter
Date: Mon, 19 Nov 2007 14:23:13 -0800 (PST)	[thread overview]
Message-ID: <20071119.142313.63549156.davem@davemloft.net> (raw)
In-Reply-To: <20071119152933.GA19126@one.firstfloor.org>

From: Andi Kleen <andi@firstfloor.org>
Date: Mon, 19 Nov 2007 16:29:33 +0100

> > > > 
> > > > All of our options suck, we just have to choose the least sucking one
> > > > and right now to me that's decrementing the counter as much as I
> > > > empathize with the SNMP application overflow detection issue.
> > > 
> > > If the SNMP monitor detects an false overflow the error it reports 
> > > will be much worse than a single missing packet. So you would replace 
> > > one error with a worse error.
> > 
> > This can be fixed, the above cannot.
> 
> I don't see how, short of breaking the interface
> (e.g. reporting 64bit or separate overflow counts)

As someone who just spent an entire weekend working on
cpu performance counter code, I know it's possible.

When you overflow, the new value is "a lot" less than
the last sampled one.  When the value backtracks like
we're discussing it could here, it only decrease
a very little bit.

  reply	other threads:[~2007-11-19 22:23 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-16  2:46 [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter Wang Chen
2007-11-16  2:54 ` David Miller
2007-11-16  3:18   ` Wang Chen
2007-11-16  4:04     ` David Miller
2007-11-16  4:13       ` Wang Chen
2007-11-16 17:02       ` Benny Amorsen
2007-11-16  4:11     ` Herbert Xu
2007-11-16  4:17       ` Wang Chen
2007-11-17 13:18         ` Andi Kleen
2007-11-18  0:09           ` David Miller
2007-11-18 21:45             ` Andi Kleen
2007-11-18 22:40               ` David Miller
2007-11-19  1:09                 ` Herbert Xu
2007-11-19  8:26                   ` David Miller
2007-11-19  2:02                 ` Wang Chen
2007-11-19  8:30                   ` David Miller
2007-11-19  4:41                 ` Herbert Xu
2007-11-19  8:32                   ` David Miller
2007-11-19 11:49                   ` Arnaldo Carvalho de Melo
2007-11-19 15:29                 ` Andi Kleen
2007-11-19 22:23                   ` David Miller [this message]
2007-11-20  5:29                     ` Bill Fink
2007-11-20  6:15                       ` David Miller
2007-11-20  6:25                         ` Wang Chen
2007-11-20  6:31                           ` Herbert Xu
2007-11-20 14:05                       ` Andi Kleen
2007-11-21  1:39                         ` David Miller
2007-11-29  7:55                           ` Wang Chen
2007-11-29  9:21                             ` Herbert Xu
2007-11-29 10:08                               ` Wang Chen
2007-11-29 10:21                                 ` Herbert Xu
2007-11-29 10:33                                   ` Wang Chen
2007-11-29 10:38                                     ` Herbert Xu
2007-11-29 10:56                                 ` Gerrit Renker
2007-11-29 12:01                                   ` Herbert Xu
2007-11-18 22:14             ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071119.142313.63549156.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andi@firstfloor.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=wangchen@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).