From: "Arnaldo Carvalho de Melo" <acme@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
andi@firstfloor.org, wangchen@cn.fujitsu.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter
Date: Mon, 19 Nov 2007 09:49:36 -0200 [thread overview]
Message-ID: <20071119114936.GE14882@ghostprotocols.net> (raw)
In-Reply-To: <20071119044117.GA1880@gondor.apana.org.au>
Em Mon, Nov 19, 2007 at 12:41:17PM +0800, Herbert Xu escreveu:
> On Sun, Nov 18, 2007 at 02:40:10PM -0800, David Miller wrote:
> >
> > This can be fixed, the above cannot.
>
> That's a good point. Perhaps one way of getting that info to
> the user without putting it in UDPInDatagrams is to create an
> inet_diag interface for UDP and put the number of queued packets
> for each socket in it.
This is something I would love to see: UDP refactored so that it gets
its hash tables/lookup code more and more looking like what we have in
inet_hashtables (struct inet_hashinfo, etc) so that udp_diag would just
fit in the inet_diag infrastructure, like dccp, that is in some aspects
like TCP and in others like UDP and already uses this infrastructure.
- Arnaldo
next prev parent reply other threads:[~2007-11-19 11:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 2:46 [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter Wang Chen
2007-11-16 2:54 ` David Miller
2007-11-16 3:18 ` Wang Chen
2007-11-16 4:04 ` David Miller
2007-11-16 4:13 ` Wang Chen
2007-11-16 17:02 ` Benny Amorsen
2007-11-16 4:11 ` Herbert Xu
2007-11-16 4:17 ` Wang Chen
2007-11-17 13:18 ` Andi Kleen
2007-11-18 0:09 ` David Miller
2007-11-18 21:45 ` Andi Kleen
2007-11-18 22:40 ` David Miller
2007-11-19 1:09 ` Herbert Xu
2007-11-19 8:26 ` David Miller
2007-11-19 2:02 ` Wang Chen
2007-11-19 8:30 ` David Miller
2007-11-19 4:41 ` Herbert Xu
2007-11-19 8:32 ` David Miller
2007-11-19 11:49 ` Arnaldo Carvalho de Melo [this message]
2007-11-19 15:29 ` Andi Kleen
2007-11-19 22:23 ` David Miller
2007-11-20 5:29 ` Bill Fink
2007-11-20 6:15 ` David Miller
2007-11-20 6:25 ` Wang Chen
2007-11-20 6:31 ` Herbert Xu
2007-11-20 14:05 ` Andi Kleen
2007-11-21 1:39 ` David Miller
2007-11-29 7:55 ` Wang Chen
2007-11-29 9:21 ` Herbert Xu
2007-11-29 10:08 ` Wang Chen
2007-11-29 10:21 ` Herbert Xu
2007-11-29 10:33 ` Wang Chen
2007-11-29 10:38 ` Herbert Xu
2007-11-29 10:56 ` Gerrit Renker
2007-11-29 12:01 ` Herbert Xu
2007-11-18 22:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071119114936.GE14882@ghostprotocols.net \
--to=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).