From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: horms@verge.net.au, netdev@vger.kernel.org, pekkas@netcore.fi,
kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, jmorris@namei.org,
kaber@coreworks.de
Subject: Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions
Date: Tue, 20 Nov 2007 00:03:13 -0800 (PST) [thread overview]
Message-ID: <20071120.000313.49219676.davem@davemloft.net> (raw)
In-Reply-To: <1195543124.4675.114.camel@localhost>
From: Joe Perches <joe@perches.com>
Date: Mon, 19 Nov 2007 23:18:44 -0800
> On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote:
> > Also, as the function names are longer than the macro name
> > you are creating lines that are > 80 columns wide that used
> > not to be in that state. For my eyes that reduced readability
> > (substantially).
>
> David? You want a patch for that too?
These patches are just clumsy and awkward, this much I will
say.
BTW, these seemingly odd macro names come from BSD.
Terefore they are quite readable for many of us :-)
I don't know what to do with these patches, they feel like
just plain noise to me even though I like the type checking.
I'm going to defer for now, sorry.
next prev parent reply other threads:[~2007-11-20 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 6:40 [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions Joe Perches
2007-11-20 7:06 ` Simon Horman
2007-11-20 7:18 ` Joe Perches
2007-11-20 7:42 ` Simon Horman
2007-11-20 8:03 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-14 15:53 Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120.000313.49219676.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kaber@coreworks.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).