netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valentine Barshak <vbarshak@ru.mvista.com>
To: linuxppc-dev@ozlabs.org
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: [PATCH 3/3] PowerPC: ibm_newemac call dev_set_drvdata() before tah_reset()
Date: Fri, 23 Nov 2007 22:14:10 +0300	[thread overview]
Message-ID: <20071123191410.GA25742@ru.mvista.com> (raw)
In-Reply-To: <20071123190747.GA25654@ru.mvista.com>

The patch moves dev_set_drvdata(&ofdev->dev, dev) up before tah_reset(ofdev)
is called to avoid a NULL pointer dereference, since tah_reset uses drvdata.

Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
---
 drivers/net/ibm_newemac/tah.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -pruN linux-2.6.orig/drivers/net/ibm_newemac/tah.c linux-2.6/drivers/net/ibm_newemac/tah.c
--- linux-2.6.orig/drivers/net/ibm_newemac/tah.c	2007-11-23 21:27:57.000000000 +0300
+++ linux-2.6/drivers/net/ibm_newemac/tah.c	2007-11-23 21:35:12.000000000 +0300
@@ -116,13 +116,14 @@ static int __devinit tah_probe(struct of
 		goto err_free;
 	}
 
+	dev_set_drvdata(&ofdev->dev, dev);
+
 	/* Initialize TAH and enable IPv4 checksum verification, no TSO yet */
 	tah_reset(ofdev);
 
 	printk(KERN_INFO
 	       "TAH %s initialized\n", ofdev->node->full_name);
 	wmb();
-	dev_set_drvdata(&ofdev->dev, dev);
 
 	return 0;

  parent reply	other threads:[~2007-11-23 19:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-23 19:07 [PATCH 0/3] PowerPC: ibm_newemac minor fixes Valentine Barshak
2007-11-23 19:10 ` [PATCH 1/3] PowerPC: ibm_newemac correct opb_bus_freq value Valentine Barshak
2007-11-23 19:11 ` [PATCH 2/3] PowerPC: ibm_newemac tah_ph typo fix Valentine Barshak
2007-11-23 19:14 ` Valentine Barshak [this message]
2007-11-24  1:18 ` [PATCH 0/3] PowerPC: ibm_newemac minor fixes Benjamin Herrenschmidt
2007-11-24  1:20   ` Jeff Garzik
2007-11-24  1:31     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071123191410.GA25742@ru.mvista.com \
    --to=vbarshak@ru.mvista.com \
    --cc=jgarzik@pobox.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).