From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Matt Mackall <mpm@selenic.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Simon Arlott <simon@fire.lp0.eu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()
Date: Fri, 23 Nov 2007 22:32:22 +0300 [thread overview]
Message-ID: <20071123193222.GA22168@2ka.mipt.ru> (raw)
In-Reply-To: <20071123191120.GA19691@waste.org>
On Fri, Nov 23, 2007 at 01:11:20PM -0600, Matt Mackall (mpm@selenic.com) wrote:
> On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote:
> > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov (johnpol@2ka.mipt.ru) wrote:
> > > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov (johnpol@2ka.mipt.ru) wrote:
> > > > Stop, we are trying to free skb without destructor and catch connection
> > > > tracking, so it is not a solution. To fix the problem we need to check
> > > > if it is not netfilter related, kind of this (not tested), Simon please
> > > > give it a try:
> > >
> > > And to be really cool we need to bypass skbs with xfrm attached, since
> > > its freeing also assumes BH context.
> >
> > What about compile options?
>
> What about my original suggestion that we mark skbs owned by netpoll
> and free only those. Much safer, no? Untested:
This should work if there are netpoll's skbs, but if we are under memory
pressure we want to free not only netpoll skbs, but at least one, and
what if there are no netpoll skbs in the queue?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2007-11-23 19:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 19:47 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable() Simon Arlott
2007-11-23 8:21 ` Andrew Morton
2007-11-23 10:55 ` Evgeniy Polyakov
2007-11-23 17:07 ` Matt Mackall
2007-11-23 17:57 ` Evgeniy Polyakov
2007-11-23 18:48 ` Evgeniy Polyakov
2007-11-23 18:51 ` Evgeniy Polyakov
2007-11-23 18:59 ` Evgeniy Polyakov
2007-11-23 19:11 ` Matt Mackall
2007-11-23 19:32 ` Evgeniy Polyakov [this message]
2007-11-23 19:41 ` Matt Mackall
2007-11-23 19:54 ` Evgeniy Polyakov
2007-11-23 20:07 ` Evgeniy Polyakov
2007-11-23 20:09 ` Matt Mackall
2007-11-24 18:19 ` Matt Mackall
2007-11-23 18:59 ` Matt Mackall
2007-11-23 19:15 ` Evgeniy Polyakov
2007-11-23 19:20 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123193222.GA22168@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).