From: "Arnaldo Carvalho de Melo" <acme@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-2.6.25] Fix pcounter build error without CONFIG_SMP
Date: Mon, 26 Nov 2007 13:23:05 -0200 [thread overview]
Message-ID: <20071126152305.GD14520@ghostprotocols.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711261630020.18529@kivilampi-30.cs.helsinki.fi>
Em Mon, Nov 26, 2007 at 04:35:38PM +0200, Ilpo Järvinen escreveu:
>
> I keep getting this build error and couldn't find anyone fixing
> it in archives. ...Maybe all net developers except me build
> just SMP kernels :-).
Thank you! UP is for sissies anyway :-P
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> In file included from include/net/sock.h:50,
> from ipc/mqueue.c:35:
> include/linux/pcounter.h: In function 'pcounter_add':
> include/linux/pcounter.h:87: error: 'struct pcounter' has no
> member named 'value'
> make[1]: *** [ipc/mqueue.o] Error 1
> make: *** [ipc] Error 2
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> ---
> include/linux/pcounter.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/pcounter.h b/include/linux/pcounter.h
> index 620aade..9c4760a 100644
> --- a/include/linux/pcounter.h
> +++ b/include/linux/pcounter.h
> @@ -84,7 +84,7 @@ static inline int pcounter_getval(const struct pcounter *self)
>
> static inline void pcounter_add(struct pcounter *self, int inc)
> {
> - self->value += inc;
> + self->val += inc;
> }
>
> static inline int pcounter_getval(const struct pcounter *self)
> --
> 1.5.0.6
next prev parent reply other threads:[~2007-11-26 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 14:35 [PATCH net-2.6.25] Fix pcounter build error without CONFIG_SMP Ilpo Järvinen
2007-11-26 15:23 ` Arnaldo Carvalho de Melo [this message]
2007-11-26 15:36 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071126152305.GD14520@ghostprotocols.net \
--to=acme@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).