[PATCH net-2.6.25] Fix pcounter build error without CONFIG_SMP

[PATCH net-2.6.25] Fix pcounter build error without CONFIG_SMP

[Ilpo Järvinen]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1008 bytes --]


I keep getting this build error and couldn't find anyone fixing
it in archives. ...Maybe all net developers except me build
just SMP kernels :-).

In file included from include/net/sock.h:50,
                 from ipc/mqueue.c:35:
include/linux/pcounter.h: In function 'pcounter_add':
include/linux/pcounter.h:87: error: 'struct pcounter' has no
member named 'value'
make[1]: *** [ipc/mqueue.o] Error 1
make: *** [ipc] Error 2

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 include/linux/pcounter.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/pcounter.h b/include/linux/pcounter.h
index 620aade..9c4760a 100644
--- a/include/linux/pcounter.h
+++ b/include/linux/pcounter.h
@@ -84,7 +84,7 @@ static inline int pcounter_getval(const struct pcounter *self)
 
 static inline void pcounter_add(struct pcounter *self, int inc)
 {
-	self->value += inc;
+	self->val += inc;
 }
 
 static inline int pcounter_getval(const struct pcounter *self)
-- 
1.5.0.6

Re: [PATCH net-2.6.25] Fix pcounter build error without CONFIG_SMP

[Arnaldo Carvalho de Melo]

Em Mon, Nov 26, 2007 at 04:35:38PM +0200, Ilpo Järvinen escreveu:
> 
> I keep getting this build error and couldn't find anyone fixing
> it in archives. ...Maybe all net developers except me build
> just SMP kernels :-).

Thank you! UP is for sissies anyway :-P

Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
 
> In file included from include/net/sock.h:50,
>                  from ipc/mqueue.c:35:
> include/linux/pcounter.h: In function 'pcounter_add':
> include/linux/pcounter.h:87: error: 'struct pcounter' has no
> member named 'value'
> make[1]: *** [ipc/mqueue.o] Error 1
> make: *** [ipc] Error 2
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> ---
>  include/linux/pcounter.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/pcounter.h b/include/linux/pcounter.h
> index 620aade..9c4760a 100644
> --- a/include/linux/pcounter.h
> +++ b/include/linux/pcounter.h
> @@ -84,7 +84,7 @@ static inline int pcounter_getval(const struct pcounter *self)
>  
>  static inline void pcounter_add(struct pcounter *self, int inc)
>  {
> -	self->value += inc;
> +	self->val += inc;
>  }
>  
>  static inline int pcounter_getval(const struct pcounter *self)
> -- 
> 1.5.0.6

Re: [PATCH net-2.6.25] Fix pcounter build error without CONFIG_SMP

[Herbert Xu]

On Mon, Nov 26, 2007 at 01:23:05PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Mon, Nov 26, 2007 at 04:35:38PM +0200, Ilpo Järvinen escreveu:
> > 
> > I keep getting this build error and couldn't find anyone fixing
> > it in archives. ...Maybe all net developers except me build
> > just SMP kernels :-).
> 
> Thank you! UP is for sissies anyway :-P
> 
> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Ilpo, you need a new machine :)

Thanks for fixing this! Patch applied to net-2.6.25.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt