From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, Tim Gardner <tim.gardner@canonical.com>
Subject: [PATCH 3/3] sky2: turn of dynamic Tx watermark workaround (FE+ only)
Date: Tue, 27 Nov 2007 11:02:07 -0800 [thread overview]
Message-ID: <20071127110207.0d65e820@freepuppy.rosehill> (raw)
In-Reply-To: <20071127110036.0268c0a9@freepuppy.rosehill>
Add workaround for issues FE+ (A0) transmit watermark.
This is copied verbatim from vendor driver sk98lin (10.22.4.3).
Don't have that chip version and no more information seems to be available.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
--- a/drivers/net/sky2.c 2007-11-26 14:02:36.000000000 -0800
+++ b/drivers/net/sky2.c 2007-11-26 14:28:47.000000000 -0800
@@ -845,6 +845,13 @@ static void sky2_mac_init(struct sky2_hw
sky2_set_tx_stfwd(hw, port);
}
+ if (hw->chip_id == CHIP_ID_YUKON_FE_P &&
+ hw->chip_rev == CHIP_REV_YU_FE2_A0) {
+ /* disable dynamic watermark */
+ reg = sky2_read16(hw, SK_REG(port, TX_GMF_EA));
+ reg &= ~TX_DYN_WM_ENA;
+ sky2_write16(hw, SK_REG(port, TX_GMF_EA), reg);
+ }
}
/* Assign Ram Buffer allocation to queue */
next prev parent reply other threads:[~2007-11-27 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 18:57 [PATCH 1/3] sky2: revert to access PCI config via device space Stephen Hemminger
[not found] ` <20071127110036.0268c0a9@freepuppy.rosehill>
2007-11-27 19:02 ` Stephen Hemminger [this message]
2007-11-27 19:02 ` [PATCH 2/3] sky2: don't use AER routines Stephen Hemminger
2007-12-01 21:34 ` [PATCH 1/3] sky2: revert to access PCI config via device space Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127110207.0d65e820@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).