From: Christoph Hellwig <hch@infradead.org>
To: "Love, Robert W" <robert.w.love@intel.com>
Cc: linux-scsi@vger.kernel.org, "Waskiewicz Jr,
Peter P" <peter.p.waskiewicz.jr@intel.com>,
devel@open-fcoe.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Rob Love <robert.w.love@linux.intel.com>,
"Leech, Christopher" <christopher.leech@intel.com>,
"Zou, Yi" <yi.zou@intel.com>, "Dev, Vasu" <vasu.dev@intel.com>,
james.bottomley@hansenpartnership.com, davem@davemloft.net,
jeff@garzik.org, "Kok, Auke-jan H" <auke-jan.h.kok@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
"Van De Ven, Arjan" <arjan.van.de.ven@intel.com>,
Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
Date: Wed, 28 Nov 2007 07:44:26 +0000 [thread overview]
Message-ID: <20071128074426.GA30468@infradead.org> (raw)
In-Reply-To: <10A7D0016239E24092DEF05CCC582E43028A636B@fmsmsx411.amr.corp.intel.com>
I just did a very quick glance over the tree. Some extremly highlevel
comments to start with before actually starting the source review:
- why do you need your own libcrc? lib/crc32.c has a crc32_le
- libsa should go. Much of it is just wrappers of kernel functions
that should be used directly. Other like that hash, even or state
helpers might either be opencoded in the caller or made completely
generic in lib/. Probably the former but we'll have to see.
next prev parent reply other threads:[~2007-11-28 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 18:49 [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project Love, Robert W
2007-11-28 7:44 ` Christoph Hellwig [this message]
2007-11-28 17:53 ` Chris Leech
2007-11-28 20:08 ` [Open-FCoE] " Joe Eykholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128074426.GA30468@infradead.org \
--to=hch@infradead.org \
--cc=arjan.van.de.ven@intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=christopher.leech@intel.com \
--cc=davem@davemloft.net \
--cc=devel@open-fcoe.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=jeff@garzik.org \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=robert.w.love@intel.com \
--cc=robert.w.love@linux.intel.com \
--cc=vasu.dev@intel.com \
--cc=yi.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).