From: Masahide NAKAMURA <nakam@linux-ipv6.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 6/7] [IPSEC]: Lock state when copying non-atomic fields to user-space
Date: Wed, 28 Nov 2007 10:16:40 +0900 [thread overview]
Message-ID: <200711281016.40946.nakam@linux-ipv6.org> (raw)
In-Reply-To: <20071126110720.GA26479@gondor.apana.org.au>
Herbert,
Monday 26 November 2007 20:07, Herbert Xu wrote:
> On Mon, Nov 26, 2007 at 11:18:45AM +0800, Herbert Xu wrote:
> >
> > I'm just going to revert this patch for 2.6.24 since we've lived
> > with this race for so long anyway.
>
> Actually, instead of reverting it completely I'm just going to
> remove the newly added locks which should be just as effective.
>
> This would reduce the churn in the code as we'd be putting most
> of it back soon anyway.
With the patch you sent, the xfrm_state_walk() issue I reported
is solved at current net-2.6.25.
--
Masahide NAKAMURA
next prev parent reply other threads:[~2007-11-28 1:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 14:35 [0/7] IPsec: More work on async crypto on output Herbert Xu
2007-10-09 14:36 ` [PATCH 1/7] [IPSEC]: Remove bogus ref count in xfrm_secpath_reject Herbert Xu
2007-10-09 20:24 ` David Miller
2007-10-09 14:36 ` [PATCH 2/7] [IPSEC]: Store IPv6 nh pointer in mac_header on output Herbert Xu
2007-10-09 20:26 ` David Miller
2007-10-09 14:36 ` [PATCH 3/7] [IPSEC]: Remove gratuitous km wake-up events on ACQUIRE Herbert Xu
2007-10-09 20:27 ` David Miller
2007-10-09 14:36 ` [PATCH 4/7] [IPSEC]: Move common code into xfrm_alloc_spi Herbert Xu
2007-10-09 20:30 ` David Miller
2007-10-09 14:36 ` [PATCH 5/7] [XFRM] user: Move attribute copying code into copy_to_user_state_extra Herbert Xu
2007-10-09 20:31 ` David Miller
2007-10-09 14:36 ` [PATCH 6/7] [IPSEC]: Lock state when copying non-atomic fields to user-space Herbert Xu
2007-10-09 20:33 ` David Miller
2007-10-10 0:48 ` Herbert Xu
2007-11-26 3:03 ` Masahide NAKAMURA
2007-11-26 3:18 ` Herbert Xu
2007-11-26 11:07 ` Herbert Xu
2007-11-28 1:16 ` Masahide NAKAMURA [this message]
2007-10-09 14:36 ` [PATCH 7/7] [IPSEC]: Move state lock into x->type->output Herbert Xu
2007-10-09 20:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711281016.40946.nakam@linux-ipv6.org \
--to=nakam@linux-ipv6.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).